Fixes to the audio screen accessibility #163
Draft
SubRighteous wants to merge 2 commits intomkckr0:devfrom
Draft
Fixes to the audio screen accessibility #163SubRighteous wants to merge 2 commits intomkckr0:devfrom
SubRighteous wants to merge 2 commits intomkckr0:devfrom
Conversation
These changes improve accessibility in the Audio screen and should address issue mkckr0#157. Fixes: mkckr0#157
These changes removed unused and unnecessary imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following request fixes the issue #157. I wasn’t sure whether the intent was to group the entire container or just the text and slider, but grouping the whole container made the most sense since TalkBack reads the entire container.
Changes
mergeDescendants = truetoConfigGroup.OutlinedCard.ColumnColumnto be the first traversal in the group followed by the sliderscontentDescriptionto ColumnTextto include the title and proper value