adding downloadable flag to library list cmd#145
adding downloadable flag to library list cmd#145rhhayward wants to merge 9 commits intomkb79:masterfrom
Conversation
|
@rhhayward |
src/audible_cli/cmds/cmd_library.py
Outdated
|
|
||
| books = await asyncio.gather( | ||
| *[_prepare_item(i) for i in library] | ||
| *[_prepare_item(i) for i in library if downloadable==False or i.is_downloadable()] |
There was a problem hiding this comment.
Instead of writing downloadable==False it should be downloadable is False.
mkb79
left a comment
There was a problem hiding this comment.
Code work as is. downloadable==False should be rewritten to downloadable is False.
|
@rhhayward |
|
Sure, I can do that. Here's what I'm thinking: and then I'll create flags based on the contents for |
|
@mkb79 - I've changed to the --filter format. Let me know what you think. |
…ard/audible-cli into library-list-downloadable
There was a problem hiding this comment.
The decrypt command should be implemented in another PR to better track changes.
Hi @mkb79,
I've taken a stab at adding a "--downloadable" flag for the library list command. I tried to duplicate the pattern of the existing "--resolve-podcasts" flag, but if there's a better way please let me know. I also had to add "customer_rights" to the response_groups list to populate the necessary field for the is_downloadable() function.
I also haven't tested this with podcasts, or other types of resources, so if there's tests you'd suggest please let me know.
Thanks,
rhhayward