CMake compatibility and Modulated code #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mming code to add CMake compatibility
Fixed simple bugs when i build for windows
…lls poisson reconstruction function and uses xml to read arguments
…s and the arguments are read using an XML file and removed ISO C++ warnings
…mals with surface trim and can handle roughness and metallic values
…t the samples have non-zero normals but there are two
…upport for double precision and reverting DATA_DEGREE back to original
|
I'd really like for CMake compatibility. Could this be merged? |
jasjuang
force-pushed
the
master
branch
5 times, most recently
from
36f911a to
1d05b3a
Compare
|
Where is InputPointStreamWithData defined in the new https://github.com/migr8/poisson-recon ? It seems InputPointStreamWithData is mentioned #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used the original code to generate some result and that works like a charm. But it's a little inconvenient to use this in my project directly because it does not include a CMakeLists.txt so that anyone can install it as a library.
I have refactored the code in modules and apps. Modules have headers and implementation files while apps contains the Poisson Reconstruction, SSD Reconstruction and Surface Trimming final codes.
The main objective is to make the code CMake compatible so that anyone can install/uninstall the code as a library. I have tested the code in Ubuntu 16.04 and it works. Ideally it should also work for windows.
Build Instructions:
$ mkdir build
$ cd build
$ cmake ..
$ make -j
If anyone wants to install as library--
sudo make install
to uninstall--
sudo make uninstall
Thank you,
Ahmad