Skip to content

Additional refactoring and consolidation#120

Merged
mkaz merged 4 commits intomainfrom
refactor/v3
Sep 7, 2025
Merged

Additional refactoring and consolidation#120
mkaz merged 4 commits intomainfrom
refactor/v3

Conversation

@mkaz
Copy link
Owner

@mkaz mkaz commented Sep 6, 2025

  • Add additional module tests and examples (see tests/module-test*.py)
  • Move vertical chart to chart class
  • Move normalize() out of utils and into data class
  • Fixes for missed duplicate escape code / color issue
  • Continue refactor duplicate code in util function
  • Convert old .format() calls to f-strings to simplify

mkaz added 3 commits September 6, 2025 07:03
- Missed a duplicate escape code / color issue
- Refactor duplicate format code into util function
- Convert old .format() calls to f-strings to simplify
@mkaz mkaz force-pushed the refactor/v3 branch 2 times, most recently from 4f91b27 to cfbf598 Compare September 7, 2025 13:18
Remove uv.lock from repo - helps version testing
@mkaz mkaz merged commit 41adfd4 into main Sep 7, 2025
2 checks passed
@mkaz mkaz deleted the refactor/v3 branch September 7, 2025 13:39
TarEnethil added a commit to TarEnethil/termgraph that referenced this pull request Feb 25, 2026
Support for the --no-readable argument was (accidentally?) removed in
41adfd4 Additional refactoring and consolidation (mkaz#120).

With the refactored version of format_value, this is now an easy fix.
Only call cvt_to_readable if no_readable is False (as it was before). It
now also works for all chart types.

Fixes 41adfd4

Signed-off-by: Thorben Roemer <thorbenroemer@t-online.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant