[Silabs] Refactor SiWx917 Wi-Fi Application implementation #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -185,13 +185,13 @@ void SilabsMatterConfig::AppInit() | |||
| { | |||
| GetPlatform().Init(); | |||
| sMainTaskHandle = osThreadNew(ApplicationStart, nullptr, &kMainTaskAttr); | |||
| SILABS_LOG("Starting scheduler"); | |||
| ChipLogProgress(DeviceLayer, "Starting scheduler"); | |||
There was a problem hiding this comment.
Why do you choose Appserver for some and DeviceLayer for others here?
There was a problem hiding this comment.
Arbitrary choice - i wasn't sure which i should take
mkardous-silabs
force-pushed
the
feature/wifi_clean_up
branch
from
37f9402
to
f2ff7eb
Compare
github-actions
bot
added
integrations
docker
tools
tests
matter-1.4-te2-script-change
app
darwin
labels
mkardous-silabs
force-pushed
the
feature/wifi_clean_up
branch
from
f2ff7eb
to
d252810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR transitions the SiWx917 Wi-Fi implementation to use the sl_net API. This allows us to leverage the LwIP integration of the Wi-Fi SDK instead of using the one implemented for Matter for the SiWx917.
Tests
Siw917x build, flash and commission