Skip to content

Commit

Permalink
Adding silabs & nordic as reviewer groups (project-chip#5274)
Browse files Browse the repository at this point in the history
* Adding silabs & nodic

* Typt
  • Loading branch information
woody-apple authored Mar 9, 2021
1 parent ae1370b commit 4e87eb8
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# Current reviewers-XXX teams, who review everything for approval.
* @reviewers-amazon @reviewers-apple @reviewers-comcast @reviewers-google @reviewers-samsung
* @reviewers-amazon @reviewers-apple @reviewers-comcast @reviewers-google @reviewers-nordic @reviewers-samsung @reviewers-silabs
16 changes: 16 additions & 0 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@ groups:
teams: [reviewers-google]
reviews:
request: 2
shared-reviewers-nordic:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-nordic]
reviews:
request: 2
shared-reviewers-samsung:
type: optional
conditions:
Expand All @@ -107,6 +115,14 @@ groups:
teams: [reviewers-samsung]
reviews:
request: 2
shared-reviewers-silabs:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-silabs]
reviews:
request: 2

############################################################
# Base Required Reviewers
Expand Down
23 changes: 10 additions & 13 deletions REVIEWERS.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
The following individuals can be chosen as, and act as required reviewers on any
PR
People from the following groups can be chosen as, and act as required reviewers
on any PR

| Name | Company |
| ----------------------------------------------- | ------------------- |
| [anush-apple](https://github.com/anush-apple) | Apple, Inc. |
| [msandstedt](https://github.com/msandstedt) | Samsung SmartThings |
| [chrisdecenzo](https://github.com/chrisdecenzo) | Amazon, Inc. |
| [hawk248](https://github.com/hawk248) | Comcast, Inc. |
| [jelderton](https://github.com/jelderton) | Comcast, Inc. |
| [andy31415](https://github.com/andy31415) | Google, Inc. |
| [robszewczyk](https://github.com/robszewczyk) | Google, Inc. |
| [saurabhst](https://github.com/saurabhst) | Samsung SmartThings |
| [woody-apple](https://github.com/woody-apple) | Apple, Inc. |
| Group | Company |
| --------------------------------------------------------------------------------- | -------------------- |
| [reviewers-apple](https://github.com/orgs/project-chip/teams/reviewers-apple) | Apple, Inc. |
| [reviewers-comcast](https://github.com/orgs/project-chip/teams/reviewers-comcast) | Comcast, Inc. |
| [reviewers-google](https://github.com/orgs/project-chip/teams/reviewers-google) | Google, Inc. |
| [reviewers-nordic](https://github.com/orgs/project-chip/teams/reviewers-nordic) | Nordic Semiconductor |
| [reviewers-samsung](https://github.com/orgs/project-chip/teams/reviewers-samsung) | Samsung SmartThings |
| [reviewers-silabs](https://github.com/orgs/project-chip/teams/reviewers-silabs) | Silicon Labs |

0 comments on commit 4e87eb8

Please sign in to comment.