Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error 404 when the path in the base URL is not empty #122

Closed
m4r1vs opened this issue Nov 8, 2024 · 3 comments
Closed

Error 404 when the path in the base URL is not empty #122

m4r1vs opened this issue Nov 8, 2024 · 3 comments

Comments

@m4r1vs
Copy link
Contributor

m4r1vs commented Nov 8, 2024 •
edited
Loading

Desktop (please complete the following information):

  • OS: Linux 6.11.6-arch1-1
  • Terminal Alacritty
  • Architecture: x86
  • Fjira version: From source (commit db02e39)

Describe the bug
When the API URL includes a path, after initializing fjira, I do not get a
list of projects but a 404 instead.

To Reproduce
Steps to reproduce the behavior:

Set config like this

current: default
workspaces:
    default:
        jiraRestUrl: https://tgipm.informatik.uni-hamburg.de/jira/
        jiraToken: TOKEN
        iraUsername: USERNAME
        jiraTokenType: personal token

Run fjira. Notice the /jira in the path of jiraRestUrl. The error is caused by https://tgipm.informatik.uni-hamburg.de/restApi being called instead of https://tgipm.informatik.uni-hamburg.de/jira/restApi.

Expected behavior
See project list.

Actual Behavior
Get Error 404

Additional notes
m4r1vs added a commit to m4r1vs/fjira that referenced this issue Nov 8, 2024
@m4r1vs
fix(mk-5#122): join basePath and restPath correctly in jiraRequest
be3b82f
@mk-5
Copy link
Owner

mk-5 commented Nov 12, 2024

@m4r1vs thanks for a report! I will check PR right away

mk-5 pushed a commit that referenced this issue Nov 12, 2024
@m4r1vs @mk-5
fix(#122): join basePath and restPath correctly in jiraRequest
57d7e93
@mk-5
Copy link
Owner

mk-5 commented Nov 12, 2024 •
edited
Loading

@m4r1vs I've merged it - but I think it would be nice to add some unit test for that paths combine logic. I will add it

mk-5 added a commit that referenced this issue Nov 12, 2024
@mk-5
misc(#122): add unit test for jira request URI combine logic
7cc96e6
mk-5 added a commit that referenced this issue Nov 13, 2024
@mk-5
misc(#122): add unit test for jira request URI combine logic
cb9ec86
@mk-5
Copy link
Owner

mk-5 commented Nov 13, 2024 •
edited
Loading

fixed in 1.4.4

@mk-5 mk-5 closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m4r1vs @mk-5