Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crypto
module brings a huge amount of code to the browser build and it's removal reduces the build size by 400 KiB or by 25%.The
crypto.randomBytes
Generates cryptographically strong pseudorandom data. That strength is not needed since these hex strings are used only as ids/classes in the generated HTML.This change may cause test fails for some users, but this can be fixed by stubbing
Math.random
.Another option would be to generate sequential IDs:
This won't cause problems with tests but may reveal the amount of e-mails generated by some application (if used on the server side).