Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots for translation guide #520

Merged
merged 11 commits into from
Nov 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2023

Follow up to #514.
Adds screenshots to guide for: POEditor, GNOME Builder, Github.
Check here: https://github.com/Vovkiv/extension-manager/tree/screenshots-for-translation-guide/po
Also might change or additional steps due do screenshots.

Initially, I wanted to use webp images for smallest size possible, but since there chance that some browsers don't support webp, used png instead. I compressed them with Curtail and removed metadata.

Copy link
Owner

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for putting this together.

Is this ready to merge?

@ghost
Copy link
Author

ghost commented Nov 20, 2023

Not yet, only around ~25% or screenshots ready

Copy link
Collaborator

@oscfdezdz oscfdezdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Is it ready now?

@ghost
Copy link
Author

ghost commented Nov 20, 2023

Looks fantastic! Is it ready now?

I think yes

@ghost ghost changed the title Draft: Add screenshots for translation guide Add screenshots for translation guide Nov 20, 2023
@ghost ghost marked this pull request as ready for review November 20, 2023 14:00
@oscfdezdz oscfdezdz merged commit f37f967 into mjakeman:master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants