Skip to content

Enhance integration tests with Kafka streaming triangle counting #364

Merged
miyurud merged 17 commits into
miyurud:masterfrom
Nayanatharapmc:test-strian
May 13, 2026
Merged

Enhance integration tests with Kafka streaming triangle counting #364
miyurud merged 17 commits into
miyurud:masterfrom
Nayanatharapmc:test-strian

Conversation

@Nayanatharapmc
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 24, 2026 12:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Kafka to the integration environment and extends the integration test suite to exercise streaming triangle counting via the adstrmk/strian flow, while also removing hard-coded graph IDs from several Cypher tests.

Changes:

  • Add Kafka service to the integration docker-compose.yml and configure JasmineGraph to depend on it.
  • Extend tests/integration/test.py with Kafka setup/produce/consume helpers and a new streaming triangle counting test.
  • Add integration config files for Kafka and JasmineGraph server properties.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/integration/test.py Adds Kafka/streaming test helpers, runs a new strian integration test, and replaces hard-coded graph IDs with IDs parsed from lst.
tests/integration/env_init/config/kafka/consumer.properties Adds Kafka host configuration for a non-default consumer config path.
tests/integration/env_init/config/jasminegraph-server.properties Provides integration-time server config with Kafka bootstrap set to kafka:29092.
tests/integration/docker-compose.yml Adds a Kafka service and wires JasmineGraph to depend on it; mounts the integration server properties file.
test-docker.sh Makes HDFS safemode handling more robust and fixes the final docker tag command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/integration/test.py Outdated
Comment thread tests/integration/test.py Outdated
Comment thread tests/integration/test.py Outdated
Comment thread tests/integration/test.py Outdated
Comment thread tests/integration/test.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 1.11%. Comparing base (b8e81b9) to head (9ff838b).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #364   +/-   ##
======================================
  Coverage    1.11%   1.11%           
======================================
  Files         110     110           
  Lines       27014   27014           
  Branches    17679   17679           
======================================
  Hits          302     302           
  Misses      26454   26454           
  Partials      258     258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

Comment thread tests/integration/env_init/config/jasminegraph-server.properties Outdated
Comment thread tests/integration/integration_workflow_streaming.py Outdated
Comment thread tests/integration/integration_workflow_streaming.py Outdated
Copy link
Copy Markdown
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put some comments. Please address all of those.

@sonarqubecloud
Copy link
Copy Markdown

@miyurud miyurud merged commit 90b95df into miyurud:master May 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants