Skip to content

Integrating sheep partitioning algorithm for JasmineGraph#362

Open
Gayan-Kaushalya wants to merge 71 commits into
miyurud:masterfrom
Gayan-Kaushalya:sheep
Open

Integrating sheep partitioning algorithm for JasmineGraph#362
Gayan-Kaushalya wants to merge 71 commits into
miyurud:masterfrom
Gayan-Kaushalya:sheep

Conversation

@Gayan-Kaushalya
Copy link
Copy Markdown
Contributor

No description provided.

@Gayan-Kaushalya Gayan-Kaushalya marked this pull request as draft March 20, 2026 18:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 0% with 1185 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.16%. Comparing base (e3abb83) to head (2b959bd).

Files with missing lines Patch % Lines
...ntend/core/executor/impl/TriangleCountExecutor.cpp 0.00% 425 Missing ⚠️
src/partitioner/local/SheepPartitioner.cpp 0.00% 230 Missing ⚠️
src/frontend/JasmineGraphFrontEnd.cpp 0.00% 149 Missing ⚠️
src/frontend/ui/JasmineGraphFrontEndUI.cpp 0.00% 83 Missing ⚠️
src/query/algorithms/triangles/SheepTriangles.cpp 0.00% 64 Missing ⚠️
src/server/JasmineGraphInstanceService.cpp 0.00% 61 Missing ⚠️
src/util/Utils.cpp 0.00% 51 Missing ⚠️
src/frontend/core/scheduler/JobScheduler.cpp 0.00% 49 Missing ⚠️
src/server/JasmineGraphServer.cpp 0.00% 41 Missing ⚠️
.../core/executor/impl/SheepTriangleCountExecutor.cpp 0.00% 9 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #362      +/-   ##
=========================================
- Coverage    1.18%   1.16%   -0.03%     
=========================================
  Files         111     115       +4     
  Lines       27059   27670     +611     
  Branches    17705   18040     +335     
=========================================
  Hits          321     321              
- Misses      26471   27082     +611     
  Partials      267     267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread conf/jasminegraph-server.properties Outdated
#The following folder is the location where workers keep their data.
#This is the location where the actual data storage takes place in JasmineGraph.
org.jasminegraph.server.instance.datafolder=/var/tmp/jasminegraph-localstore
org.jasminegraph.server.instance.datafolder=/var/tmp/jasminegraph-localstore-sheep
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by jasminegraph-localstore-sheep? are you creating a new data store specifically for this partitioning algorithm?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed because the other team requested to have our graph files to be stored in a separate location. This will be changed when the PR is marked ready for review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back to jasminegraph-localstore

Comment thread src/frontend/core/executor/impl/SheepTriangleCountExecutor.cpp Outdated
Comment thread src/frontend/core/executor/impl/SheepTriangleCountExecutor.h Outdated
Comment thread src/partitioner/local/SheepPartitioner.h Outdated
Comment thread src/query/algorithms/triangles/SheepTriangles.cpp Outdated
Comment thread src/query/algorithms/triangles/SheepTriangles.h Outdated
Copy link
Copy Markdown
Owner

@miyurud miyurud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all the comments by sonar cloud. In addition please address all the comments given by me.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
21.6% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Gayan-Kaushalya Gayan-Kaushalya marked this pull request as ready for review May 17, 2026 17:17
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants