[GraphRAG][v2] Implementation of Agentic Retrieval and Performance enhancement of KG construction & Semantic Beam Search by ParameswaranSajeenthiran · Pull Request #350 · miyurud/jasminegraph

ParameswaranSajeenthiran · 2026-01-20T11:15:45Z

Summary

This PR introduces the new Agentic Retrieval and improvements in Knowledge Graph (KG) construction and semantic search, focusing on performance, scalability, and reliability.

1. Agentic Retrieval

Introduced session-based agent orchestration initiated from the frontend to manage agentic retrieval workflows per user query
Implemented agent-driven query understanding, enabling interpretation of user intent and constraints from raw query text
Added semantic beam search plan generation, allowing the agent to construct and rank multi-step retrieval plans
Enabled iterative execution of beam search plans, where intermediate results inform subsequent retrieval decisions
Integrated agent-controlled response generation, synthesizing grounded responses from semantic beam search outputs

2. Knowledge Graph (KG) Construction

Implemented KG construction from PDF with support in both UI and server
Parallelized graph file persistence and embedding generation to reduce ingestion latency
Migrated online edge embedding (API during query) to offline embedding generation and indexing
Implemented tuple validation with retry mechanism for invalid tuples to improve data reliability
General code-level optimizations for ingestion and persistence
Added and extended integration tests for KG construction and persistence pipeline

2. Semantic Beam Search & Graph / Query Optimizations

Introduced Semantic Beam Search for improved multi-hop reasoning and retrieval quality
Added Fennel-based graph partitioning for better scalability
Migrated lightweight queries from processes to threads to enable shared access to large-scale indexes
General code-level optimizations for query execution
Integration tests added for search correctness and query performance

Impact

Faster and more reliable KG ingestion
Reduced dependency on runtime embedding APIs
Scalable query execution and search
Higher-quality semantic search results

Notes for Reviewers

Parallelism changes affect persistence and embedding pipelines — concurrency handling should be reviewed
Offline edge embedding migration introduces new indexing logic

Make entity deduplication thread safe

miyurud · 2026-04-13T19:20:57Z

+                if (token[i] == ':')
+                    ++colonCount;
+            }
+            util_logger.info("ColonCount: " + std::to_string(colonCount));


Suggested change

util_logger.info("ColonCount: " + std::to_string(colonCount));

util_logger.debug("ColonCount: " + std::to_string(colonCount));

Shouldn't this be a debug message?

Fixed in 2aba70d

miyurud · 2026-04-13T19:21:33Z

+            // Make sure this colon is AFTER the scheme (not the one in https://)
+            if (lastColon != std::string::npos && lastColon > token.find("://") + 2) {
+                token = token.substr(0, lastColon);
+                util_logger.info("HTTPS rule applied, stripped to: " + token);


Suggested change

util_logger.info("HTTPS rule applied, stripped to: " + token);

util_logger.debug("HTTPS rule applied, stripped to: " + token);

Fixed in 2aba70d

miyurud · 2026-04-13T19:22:03Z

+                if (lastColon != std::string::npos) {
+                    token = token.substr(0, lastColon);
+                }
+                util_logger.info("ColonCount 3");


Suggested change

util_logger.info("ColonCount 3");

Fixed in 2aba70d

miyurud · 2026-04-13T19:26:08Z

+        // if (index->ntotal % 1000 == 0) {
+        //     lock.unlock();
+        //     faiss_index_logger.info("saving faiss index periodically");
+        //     save(filePath);
+        //     faiss_index_logger.info("saved faiss index periodically");
+        //
+        // }


Suggested change

// if (index->ntotal % 1000 == 0) {

// lock.unlock();

// faiss_index_logger.info("saving faiss index periodically");

// save(filePath);

// faiss_index_logger.info("saved faiss index periodically");

//

// }

miyurud · 2026-04-13T19:26:29Z

+       // faiss_index_logger.error(std::string("Failed to reconstruct embedding for ID ") + nodeId + ": " +
+       //     e.what());


Suggested change

// faiss_index_logger.error(std::string("Failed to reconstruct embedding for ID ") + nodeId + ": " +

// e.what());

miyurud · 2026-04-13T19:27:07Z

+      // int nlist = 100000;         // number of clusters (IVF)
+      // int m = 64;                 // PQ number of sub-vectors
+      // int nbits = 8;              // 8-bit quantization
+      //
+      // faiss::IndexFlatL2 quantizer(dim);
+      //
+      // faiss::IndexIVFPQ* index = new faiss::IndexIVFPQ(
+      //     &quantizer,
+      //     dim,
+      //     nlist,     // IVF clusters
+      //     m,         // number of PQ subvectors
+      //     nbits      // bits per subvector
+      // );
+      // index->use_precomputed_table = 1;
+      // index->train(num_train_vectors, train_data);


Suggested change

// int nlist = 100000; // number of clusters (IVF)

// int m = 64; // PQ number of sub-vectors

// int nbits = 8; // 8-bit quantization

//

// faiss::IndexFlatL2 quantizer(dim);

//

// faiss::IndexIVFPQ* index = new faiss::IndexIVFPQ(

// &quantizer,

// dim,

// nlist, // IVF clusters

// m, // number of PQ subvectors

// nbits // bits per subvector

// );

// index->use_precomputed_table = 1;

// index->train(num_train_vectors, train_data);

miyurud · 2026-04-13T19:28:13Z

  static FaissIndex* getInstance(int embeddingDim, const std::string& filepath);

-  ~FaissIndex();
+  // ~FaissIndex();


Suggested change

// ~FaissIndex();

miyurud · 2026-04-13T19:28:54Z

@@ -1,2 +1,2 @@
-hdfs.host=192.168.1.19
+hdfs.host=10.8.100.22


Why did you change the IP address to this new value?

miyurud · 2026-04-14T18:04:43Z

 RESULT = subprocess.check_output(["hostname", "-I"]).decode().strip()
 SERVER_IP = RESULT.split()[0]
-HOST = "127.0.0.1"
+HOST = "10.8.100.248"


why we change the IP address here?

miyurud · 2026-04-14T18:05:35Z

@@ -0,0 +1,19 @@
+"""Copyright 2024 JasmineGraph Team


Suggested change

"""Copyright 2024 JasmineGraph Team

"""Copyright 2026 JasmineGraph Team

miyurud · 2026-04-14T18:06:26Z

@@ -0,0 +1,204 @@
+"""Copyright 2025 JasmineGraph Team


Suggested change

"""Copyright 2025 JasmineGraph Team

"""Copyright 2026 JasmineGraph Team

miyurud · 2026-04-14T18:09:25Z

+def test(host, port):
+    """Test the JasmineGraph server by sending a series of commands and checking the responses."""
+
+    # subprocess.run(['bash', OLLAMA_SETUP_SCRIPT], check=True)


Suggested change

# subprocess.run(['bash', OLLAMA_SETUP_SCRIPT], check=True)

miyurud

I have put some comments on the PR. Please fix all of them and explain how you address those by replying on each comment.

sonarqubecloud · 2026-04-16T13:55:57Z

Quality Gate failed

Failed conditions
9 Security Hotspots
18.6% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

# Conflicts: # src/frontend/JasmineGraphFrontEnd.cpp # src/frontend/JasmineGraphFrontEnd.h # src/frontend/core/executor/impl/SemanticBeamSearchExecutor.cpp # src/knowledgegraph/construction/Pipeline.cpp # src/query/processor/nlp/semanticbeamsearch/SemanticBeamSearch.cpp # src/server/JasmineGraphInstanceProtocol.cpp # src/server/JasmineGraphInstanceProtocol.h # src/server/JasmineGraphInstanceService.cpp # src/util/Utils.cpp # src/util/Utils.h # src/vectorstore/FaissIndex.cpp # test-docker.sh # test-k8s.sh

Saji master 16 5

sonarqubecloud · 2026-05-20T08:58:26Z

Quality Gate failed

Failed conditions
9 Security Hotspots
20.1% Duplication on New Code (required ≤ 3%)
D Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

abineyan and others added 30 commits December 16, 2025 00:26

implement frontend function to initiate agent retrieval job scheduler

154c27b

implement agent plan executor in executor factory

ccbbda9

implement jasminegraph frontend protocol

c7adc5c

add CMakeLists

149e396

add instance protocol

5245228

fix bug

83f2411

fix bug

41cf4af

implement semantic beam search plan builder and refactor build function

e4e45de

fix uuid bug

f5f4332

implement llm related input retrieval from frontend

cba7d06

implement agent request struct to handle llm and queries

aa7ac10

implement agent request context creation from frontend input

bd6df15

fix bug

1e858f6

add sbs system prompt

8ef23b9

implement llm reponse cleaner

84c4fce

implement plan structure

d8d597b

implement plan decoder

c84e225

Implement multithreaded queries

568fc28

update cmakelists

e295370

implement the decoder call within AgentExecutor

d45cc27

fix bugs

81cd20c

Implement multithreaded queries

463cca2

Implement Local text extract

f83b7b6

Merge branch 'raw-kg-contruction' into bug-2

043aca2

Merge pull request #21 from ParameswaranSajeenthiran/bug-2

2c9e0ef

Make entity deduplication thread safe

update graph entity and predicate type to schema.org

7abccb7

Handle retry when invalid tuple is generated by LLM

ee94b7f

implemet designated worker graphrag command call

19bfa66

add loggers for AgentPlanExecutor

62b9f6f

Fix openMode of nodeIndex

7749688

miyurud reviewed Apr 13, 2026

View reviewed changes

miyurud reviewed Apr 14, 2026

View reviewed changes

miyurud requested changes Apr 14, 2026

View reviewed changes

abineyan added 7 commits April 16, 2026 13:47

Replace string literal with constant in send_str_wrapper

86bf406

Update copyright year in Responder.cpp

198a49d

Fix variable name for worker count in AgentPlanExecutor

2ef3870

Fix retry logic for LLM response generation

d03f605

Refactor logging and thread join logic

68bc419

Fix comment formatting in JasmineGraphInstanceService.h

6394d4d

Change log level from info to debug in Utils.cpp

2aba70d

ParameswaranSajeenthiran and others added 8 commits May 16, 2026 22:42

Fix redeclaration of NON_OPERATIONAL

e03ea01

Fix connect_wrapper declaration not found

9100411

revert test-docker.sh

4072c57

revert test-docker.sh

a338be9

Update JasmineGraphInstanceService.cpp given by Gayan

38fc9da

Test enable streaming test to 0

bd5f826

Merge pull request #59 from abineyan/saji-master-16-5

ccef83a

Saji master 16 5

	util_logger.info("ColonCount: " + std::to_string(colonCount));
	util_logger.debug("ColonCount: " + std::to_string(colonCount));

	util_logger.info("HTTPS rule applied, stripped to: " + token);
	util_logger.debug("HTTPS rule applied, stripped to: " + token);

		// faiss_index_logger.error(std::string("Failed to reconstruct embedding for ID ") + nodeId + ": " +
		// e.what());

	"""Copyright 2024 JasmineGraph Team
	"""Copyright 2026 JasmineGraph Team

	"""Copyright 2025 JasmineGraph Team
	"""Copyright 2026 JasmineGraph Team

		@@ -1,2 +1,2 @@
		hdfs.host=192.168.1.19
		hdfs.host=10.8.100.22

Conversation

ParameswaranSajeenthiran commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

1. Agentic Retrieval

2. Knowledge Graph (KG) Construction

2. Semantic Beam Search & Graph / Query Optimizations

Impact

Notes for Reviewers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miyurud left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Apr 16, 2026

Quality Gate failed

Uh oh!

sonarqubecloud Bot commented May 20, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ParameswaranSajeenthiran commented Jan 20, 2026 •

edited

Loading