-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡 implement link titles in the JIRARenderer (contrib) #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franferrax, great, thanks for your contribution.
Do I see it right, that while this works, it doesn't seem to be documented (or anywhere else) by Atlassian?
Next, do you think you could also add a unit test to cover this new feature? I think cloning and extending the existing test_render_link()
as test_render_link_with_title()
could be sufficient. :)
Oh you are right! I know that documentation, I just discovered this by accident and hadn't realized this isn't there. Feel free to discard this PR if you prefer to only implement well documented features.
Yes, I'll try to do that in a separated commit. |
@franferrax, thanks for having quickly implemented the requested changes. :)
I tried to Google again and I still couldn't find anything on this Jira markup feature, like since which version of Jira it is available. Yet, I think this PR makes sense and it is probably safe to be merged. So only just for sure, for the case someone follows us, I would leave it still open for a while (like a week or two), giving them a chance to challenge this change. :)) |
Sample Markdown:
In Linux, test with:
mistletoe -r contrib.jira_renderer.JIRARenderer <(echo 'Sample: [inner](https://target "title")')
Jira result, before this PR changes:
Jira result, after this PR changes: