html.unescape in tokenizer #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-my-profile
force-pushed
the
html.unescape-in-tokenizer
branch
from
a916bac
to
8af2597
Compare
pbodnar
reviewed
Feb 13, 2022
pbodnar
reviewed
Feb 13, 2022
Python 3.6 has already reached end-of-life, so supporting 3.3 doesn't make any sense.
not-my-profile
force-pushed
the
html.unescape-in-tokenizer
branch
from
8af2597
to
fb45fb0
Compare
pbodnar
reviewed
Feb 13, 2022
pbodnar
reviewed
Feb 13, 2022
pbodnar
requested changes
Feb 13, 2022
Previously & ended up in the LaTeX when using the LaTeXRenderer, which is obviously wrong.
Previously the HTML unescaping took place in the HTMLRenderer. The LaTeXRenderer didn't do it so e.g. HTML entities in links ended up in the LaTeX output. The correct way is to resolve the HTML entities during the tokenization.
It does not make sense to put test-specific code in the code that runs in production. Escaping ' as ' is perfectly fine and CommonMark compliant. (The official CommonMark test suite actually performs HTML normalization by default).
Now that the method just calls html.escape, using it doesn't make sense anymore.
not-my-profile
force-pushed
the
html.unescape-in-tokenizer
branch
from
fb45fb0
to
6c52a20
Compare
pbodnar
approved these changes
Feb 14, 2022
|
Thank you. :) BTW You may have noticed that I'm a fan of conventional commits, if you would like to give it a try. But I won't force it on you. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes that HTML entities end up in the LaTeX output by the LaTeXRenderer. For details see the individual commits.
If you like these changes, please merge them without squashing.