Fix benchmark #119
Merged
Fix benchmark #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbodnar
requested changes
Oct 24, 2021
There was a problem hiding this comment.
@averms, thanks a lot for this fix. I have validated the changes and they generally make good sense to me. Can you just please have a look at some details within the review, plus rebase on the latest commit (or of course, I can do the rebase myself later)?
- Use new Python-Markdown API - CommonMark package was renamed commonmark - It would have conflicted with the folder test/commonmark so the folder is renamed to test/specification.
pbodnar
added a commit
that referenced
this pull request
Oct 29, 2021
pbodnar
added a commit
that referenced
this pull request
Oct 29, 2021
... because mistletoe actually only implements footlinks.
|
Hopefully all for now. :) |
|
Note: I have also re-run the benchmarks and updated the corresponding documentation: f513248, if you or anybody else would like to check... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are:
the folder is renamed to test/specification.