Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib sub-package is missing in the mistletoe 1.0.0 PyPI version #177

Closed
franferrax opened this issue Jan 19, 2023 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@franferrax
Copy link
Contributor

If I'm not misunderstanding #167, the contrib sub-package should be shipped as part of mistletoe, however it is missing from the PyPI's mistletoe==1.0.0 package, in either mistletoe-1.0.0.tar.gz or mistletoe-1.0.0-py3-none-any.whl.

Steps to reproduce

virtualenv -q venv && ./venv/bin/pip3 install mistletoe==1.0.0
./venv/bin/python -c "from mistletoe.contrib.jira_renderer import JIRARenderer"
rm -rf venv

Expected behavior

No errors occur

Actual behavior

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'mistletoe.contrib'
@pbodnar
Copy link
Collaborator

pbodnar commented Jan 19, 2023

@franferrax, thanks for reporting this issue. It looks like we need to list all exported packages explicitly here: https://github.com/miyuchina/mistletoe/blob/v1.0.0/setup.py#L11, i.e.:

- packages=['mistletoe'],
+ packages=['mistletoe', 'mistletoe.contrib'],

I will check it out on this weekend probably.

@pbodnar pbodnar self-assigned this Jan 19, 2023
@pbodnar pbodnar added the bug label Jan 19, 2023
@pbodnar pbodnar added this to the 1.0.1 milestone Jan 19, 2023
@pbodnar
Copy link
Collaborator

pbodnar commented Jan 20, 2023

Fixed in 1.0.1 - and the version has just been released. :)

@pbodnar pbodnar closed this as completed Jan 20, 2023
@franferrax
Copy link
Contributor Author

Thanks a lot @pbodnar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants