-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DlgPrefEQ: fix loading/saving main EQ parameters #4884
Conversation
Remaining issues:
Preferrable fix: |
Done, ready for review. |
src/preferences/dialog/dlgprefeq.cpp
Outdated
double paramValue = double(value - slider->minimum()) / | ||
double(slider->maximum() - slider->minimum()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the division of int / int did not return a double but int.
Casting dividend & divisor to double fixes that 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the compiler keep the type. Once one of the values is double, the result is also double.
Just use static_cast<double>()
here to be more in line with the other code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, done.
In the preferences 'update' is usually used for slots updating the GUI
@ferranpujolcamins Thank you for review. My comments are also solved. |
https://bugs.launchpad.net/mixxx/+bug/1983764
https://bugs.launchpad.net/mixxx/+bug/1983789 likely a regression from effects refactoring
Verify lp:1983764 is fixed:
Verify lp:1983789 is fixed:
Unfortunately, that pref page is still a mess, most (all?) selections are immediately applied (okay) and stored to config (not okay since is clicking
Cancel
does not reset options to prevous state).Eventually I'll port #4667 to main one day.