-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controllers: Use console.log instead of engine.log #4524
Conversation
This was the only script directly using engine.log instead of the print wrapper in common-controller-scripts.js.
86b4915
to
6d3b4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Merge?
style issues are existing old js problems, fine to ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swiftb0y ok to merge
For me console.log doesn't work. If I change common-controller-scripts.js back to engine.log the output from the script appears again. |
Did you make sure to use |
Yes |
Did you try manually defining the logging category filter? |
No, but Jan fixed this already: #4612 |
The issue is that See #4612. So |
Thank you. I just saw the PRs in the wrong order and didn't realize my comment was obsolete before I made it. |
Let's merge this uncontroversial change first. Reduces the PR size of #4523 and hopefully it will make the CI checks green, too.