[Qt6] TrackAnalysisScheduler: Remove dependency on Library #4478
Conversation
| @@ -70,11 +73,13 @@ TrackAnalysisScheduler::TrackAnalysisScheduler( | |||
| for (int threadId = 0; threadId < numWorkerThreads; ++threadId) { | |||
| m_workers.emplace_back(AnalyzerThread::createInstance( | |||
| threadId, | |||
| library->dbConnectionPool(), | |||
| pDbConnectionPool, | |||
There was a problem hiding this comment.
This will still be problematic for Qt6 :/
Do you plan to work on this next? |
Only makes sense if we have a clear vision of were we are heading to. It doesn't make any sense to refactor code that must be thrown away in the end. I am no longer wasting my time to clean up this entangled mess ...while trying to keep things working somehow and getting drawn into bikeshedding discussions. |
I agree, we should not waste time cleaning up code we intend to discard soon anyway. I thought we had agreed that we don't want to completely rewrite the analysis code though, so I think it would be worthwhile to switch TrackAnalysisScheduler from TrackId to QUrl. I think we can guard the DbConnectionPool parameter for AnalyzerThread behind QT_VERSION checks because the only analyzer that needs it is AnalyzerWaveform. |
|
Still 996 lines of linker errors in the Qt6 build |
|
I made a lot of progress with those linker errors in #4448 but further progress is blocked by TrackAnalysisScheduler's dependency on TrackId. |
No need to replace
TrackIdwithQUrlright now.This should reduce the number of linker errors for the stripped down Qt6 build.