-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SeratoBeatsImporter: Fix import/export of non-const beatgrids #3885
Conversation
I can now export the beatgrid and them import it. However, If I export the imported beatgrid again, the last marker in missing. So there is some other subtle bug in the export code. I'll investigate tomorrow. |
47c6415
to
98fcb44
Compare
98fcb44
to
b88882d
Compare
b88882d
to
e6b2d48
Compare
Yeeeees, I think I finally fixed it. Sorry, had to rewrite some parts. Please have a look and tell me when I should add comments. At least we now have proper round trip tests that check for correctness. |
Please also test this manually. Testing instructions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. My ideas/suggestions for improving safety and readability even further are optional.
LGTM |
This should fix the import of Serato BeatGrids where no non-terminal markers are present. The previous code was wrong, I don't know what I was thinking.