Pref > EQ comboboxes: show empty items always at the top #3659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
comboboxnone-top
branch
from
239d881 to
8eea813
Compare
ronso0
force-pushed
the
comboboxnone-top
branch
from
c149b89 to
ee2e55e
Compare
daschuer
approved these changes
Feb 27, 2021
|
Sure, I'm at it. Most of it are changing comments that are removed anyway.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a consistent UI, let's move all 'empty' combobox items to the top
as it is already the case in
continues #3485 as proposed in #3549 (comment)
Also, the last commit removes some noise from the EQ/QuickEffect grid (tr string changes, deletions). If this is not desired I can revert that.
before
