Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopted link to forums #3116

Merged
merged 4 commits into from
Sep 23, 2020
Merged

Conversation

christianlupus
Copy link
Contributor

The switch to discord was not made public thus the README should be updates accordingly, especially as it was not directly obvious that the phpBB forum was no longer the 1st place for forum communication.

README.md Outdated
@@ -75,7 +75,8 @@ development and community news:
- Follow us on [Twitter] and [Facebook].
- Subscribe to the [Mixxx Development Blog][blog].
- Join the developer [mailing list].
- Post on the [Mixxx forums][forums].
- Post on the [Mixxx discord channel][discord].
- Archive of the [Mixxx forums][forums].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old forum was ported to discourse entirely, so we don't need an archive link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example an old skin thread:
http://www.mixxx.org/forums/viewtopic.php?f=8&t=6052

This shouldn't even work, I guess the redirect is broken again. Ping @rryan

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I picked the link from the Dark metal PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove the link to the archives then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be resolved by da1399f.

@Holzhaus
Copy link
Member

Please rebase on 2.2.

@Be-ing Be-ing changed the base branch from master to 2.2 September 23, 2020 15:59
@Be-ing
Copy link
Contributor

Be-ing commented Sep 23, 2020

Thanks for noticing this and taking the time to fix it.

christianlupus and others added 2 commits September 23, 2020 19:09
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
@Be-ing Be-ing merged commit 1339b47 into mixxxdj:2.2 Sep 23, 2020
@christianlupus christianlupus deleted the christianlupus-patch-1 branch September 23, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants