Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MixxxDbTest base class #2980

Merged
merged 4 commits into from
Aug 1, 2020
Merged

Add MixxxDbTest base class #2980

merged 4 commits into from
Aug 1, 2020

Conversation

xeruf
Copy link
Contributor

@xeruf xeruf commented Jul 31, 2020

No description provided.

Holzhaus
Holzhaus reviewed Jul 31, 2020
View reviewed changes
@Holzhaus Holzhaus requested a review from uklotzde July 31, 2020 19:26
@xeruf xeruf force-pushed the test-mixxxdb-fixture branch from 757d6bd to 752d30a Compare August 1, 2020 10:31
@xeruf xeruf requested a review from Holzhaus August 1, 2020 10:31
Holzhaus
Holzhaus approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@Holzhaus Holzhaus merged commit 5eb9a64 into mixxxdj:master Aug 1, 2020
@Holzhaus Holzhaus added this to the 2.4.0 milestone Aug 1, 2020
@xeruf xeruf deleted the test-mixxxdb-fixture branch August 25, 2020 12:17
@xeruf xeruf mentioned this pull request Aug 29, 2020
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

@uklotzde uklotzde Awaiting requested review from uklotzde

Assignees
No one assigned
Labels
code quality
Projects
2.4 release
Status: Done
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xeruf @Holzhaus