Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for loading controller scripts as JS modules #2868

Merged
merged 29 commits into from
Jul 12, 2020
Merged

add support for loading controller scripts as JS modules #2868

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
4cf5dd0
add support for loading controller scripts as JS modules
Be-ing Jun 14, 2020
40246b5
ControllerEngine: add warning when module functions are missing
Be-ing Jun 14, 2020
6636d0e
ControllerEngine: reload JS module when the file changes
Be-ing Jun 14, 2020
1bfdaf4
load controller XML and JS module files from subdirectories
Be-ing Jun 14, 2020
537f2a1
add MidiDispatcher module in new res/controllers/lib folder
Be-ing Jun 14, 2020
60590e8
add MidiDispatcher JS library to QRC
Be-ing Jun 15, 2020
a988523
MidiDispatcher: add comment explaining noteOff option
Be-ing Jun 15, 2020
949b11b
MidiDispatcher: rename registerInputCallback to setInputCallback
Be-ing Jun 21, 2020
019bf82
ControllerEngine: show script exception dialog for module functions
Be-ing Jun 21, 2020
a1ac571
MidiDispatcher: throw Errors for invalid inputs
Be-ing Jun 21, 2020
2a9aa02
MidiDispatcher.receiveData: revert to checking if callback is function
Be-ing Jun 21, 2020
dddaab6
MidiDispatcher: add support for 2 byte program change & aftertouch
Be-ing Jun 21, 2020
d9464c0
MidiDispatcher: use noteOff option by default
Be-ing Jun 21, 2020
071b306
ControllerEngine: show error if module has no receiveData function
Be-ing Jun 21, 2020
e1e8145
MidiDispatcher: add JSDoc documentation
Be-ing Jun 21, 2020
dddccd5
MidiDispatcher: rename receiveData to receiveMidiData
Be-ing Jun 30, 2020
6ddc7bb
ControllerEngine: add ConsoleExtension into QJSEngine environment
Be-ing Jul 4, 2020
ef745f1
controllers: rename receiveData function to handleInput
Be-ing Jul 4, 2020
e4a3c58
MidiDispatcher: rename receiveMidiData function to handleMidiInput
Be-ing Jul 4, 2020
6f59d5a
MidiDispatcher: delete debug message
Be-ing Jul 5, 2020
8182c77
ControllerEngine: use millisecond precision for timestamps
Be-ing Jul 5, 2020
20f1485
fix MidiController tests
Be-ing Jul 6, 2020
328611e
MidiDispatcher: use hash function instead of JSONifying Arrays
Be-ing Jul 9, 2020
868fd04
ControllerEngine: #if QT_VERSION check for loadModule method
Be-ing Jul 9, 2020
80f18ec
MidiDispatcher: avoid a string comparison on each input message
Be-ing Jul 9, 2020
abe2624
MidiDispatcher: improve JSDoc documentation
Be-ing Jul 9, 2020
3ef56de
MidiDispatcher: more improvements to JSDoc documentation
Be-ing Jul 10, 2020
ecc740d
ControllerEngine: fix build for Qt < 5.12
Be-ing Jul 10, 2020
f963cc3
remove MidiDispatcher JS module
Be-ing Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MidiDispatcher: delete debug message
  • Loading branch information
@Be-ing
Be-ing committed Jul 9, 2020
commit 6f59d5ad3260bc27ac4d8e693ec51ec44a92ba89
1 change: 0 additions & 1 deletion res/controllers/lib/mididispatcher.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export class MidiDispatcher {
// https://www.midi.org/specifications-old/item/table-2-expanded-messages-list-status-bytes
if ((data[0] & 0xF0) == 0xC0 || (data[0] & 0xF0) === 0xD0) {
key = JSON.stringify([data[0]]);
print('SINGLE ' + data);
} else {
key = JSON.stringify([data[0], data[1]]);
}
Expand Down