Code

[WIP] Remove beatmap and beatgrid#2861

Code

Closed

hacksdump wants to merge 162 commits intomixxxdj:mastermixxxdj/mixxx:masterfrom hacksdump:remove-beatmap-beatgridhacksdump/mixxx:remove-beatmap-beatgridCopy head branch name to clipboard

+3,488-3,031

Commits

Commits on Nov 6, 2019

• Improvement in proto for beats blob

  JaviVilarroig

  committed
  148e216

  Copy full SHA for 148e216

Commits on Nov 20, 2019

• Added Signature class for storing track time signature information

  JaviVilarroig

  committed
  39a90b4

  Copy full SHA for 39a90b4

Commits on Dec 9, 2019

• Added Signature class

  JaviVilarroig

  committed
  dc8fbe7

  Copy full SHA for dc8fbe7

Commits on Dec 16, 2019

• Added Beats::getSignature

  JaviVilarroig

  committed
  9ee4695

  Copy full SHA for 9ee4695

Commits on Dec 17, 2019

• Merge branch 'bars_phrases_and_variable_BPM_in_beats_class' of https://github.com/JaviVilarroig/mixxx into bars_phrases_and_variable_BPM_in_beats_class

  JaviVilarroig

  committed
  05a4720

  Copy full SHA for 05a4720

• Fix repo

  JaviVilarroig

  committed
  2d38e75

  Copy full SHA for 2d38e75

Commits on Dec 19, 2019

• Merge remote-tracking branch 'upstream/master' into bars_phrases_and_variable_BPM_in_beats_class

  JaviVilarroig

  committed
  c1428f0

  Copy full SHA for c1428f0

Commits on Jan 13, 2020

• Added Signature manipulation to BeatGrid.

  JaviVilarroig

  committed
  590be5d

  Copy full SHA for 590be5d

Commits on Jan 16, 2020

• BeatGrid/BeatMap Signature support

  Show description for b2c9eca
  JaviVilarroig

  committed
  b2c9eca

  Copy full SHA for b2c9eca

• Removed forgotten qDebug unneeded trace

  JaviVilarroig

  committed
  0084ddc

  Copy full SHA for 0084ddc

Commits on Feb 17, 2020

• - Added button in Tango skin for setting bar beat

  Show description for c8b8ae4
  JaviVilarroig

  committed
  c8b8ae4

  Copy full SHA for c8b8ae4

Commits on Feb 22, 2020

• Presentaion of Bar beats in Waveform for BeatMap.

  Show description for fa68e2d
  JaviVilarroig

  committed
  fa68e2d

  Copy full SHA for fa68e2d

• Merge remote-tracking branch 'upstream/master' into bars_phrases_and_variable_BPM_in_beats_class

  JaviVilarroig

  committed
  87cc607

  Copy full SHA for 87cc607

Commits on Feb 25, 2020

• Adds null_signature and default_signature constants.

  JaviVilarroig

  committed
  01583e8

  Copy full SHA for 01583e8

• Rename Signature to TimeSignature in protobuff and wrapper class.

  JaviVilarroig

  committed
  b533ac4

  Copy full SHA for b533ac4

Commits on Feb 26, 2020

• Fixes in TimeSignature class.

  Show description for 72e030a
  JaviVilarroig

  committed
  72e030a

  Copy full SHA for 72e030a

Commits on Feb 28, 2020

• Protect naked pointers in BpmControl.

  JaviVilarroig

  committed
  9d652ca

  Copy full SHA for 9d652ca

• BeatMap::SetBar to use the real Signature of the track to calculate the

  Show description for 91c9930
  JaviVilarroig

  committed
  91c9930

  Copy full SHA for 91c9930

Commits on Mar 4, 2020

• Fix issue with set bar button nor properly reacting to press an hover.

  JaviVilarroig

  committed
  df0f083

  Copy full SHA for df0f083

Commits on Mar 5, 2020

• Multiple small fixes on Beats. Added default value to TimeSignature

  Show description for 26b358f
  JaviVilarroig

  committed
  26b358f

  Copy full SHA for 26b358f

Commits on Apr 19, 2020

• BeatGrid removal and BeatMap consolidation into Beats

  Show description for f97cd1e
  JaviVilarroig

  committed
  f97cd1e

  Copy full SHA for f97cd1e

• Forgoten update on cmake list for previous commit

  JaviVilarroig

  committed
  48ec71b

  Copy full SHA for 48ec71b

Commits on Jun 13, 2020

• Merge commit 'f1e13f93ad35dc1de34a6e8741f369cbb95bc71e' into bars_phrases_and_variable_BPM_in_beats_class3

  daschuer

  committed
  1b4a0d8

  Copy full SHA for 1b4a0d8

• Improve variable names for Track pointers.

  

  JaviVilarroig

  authored and

  daschuer

  committed
  769e922

  Copy full SHA for 769e922

• Improve variable names for Track pointers (2)

  

  JaviVilarroig

  authored and

  daschuer

  committed
  3647af9

  Copy full SHA for 3647af9

• Document Beats class for Doxygen

  

  JaviVilarroig

  authored and

  daschuer

  committed
  fcdc116

  Copy full SHA for fcdc116

• Fix if's without closing brackets.

  

  JaviVilarroig

  authored and

  daschuer

  committed
  4c54b7c

  Copy full SHA for 4c54b7c

• Ads operator<< to Beats and cleanup of misc malformed make_shared

  

  JaviVilarroig

  authored and

  daschuer

  committed
  dccf044

  Copy full SHA for dccf044

• Improvements in Timesignature

  

  JaviVilarroig

  authored and

  daschuer

  committed
  331ef5a

  Copy full SHA for 331ef5a

• Use mixxx::kEngineChannelCount for consistency

  

  JaviVilarroig

  authored and

  daschuer

  committed
  0a7baad

  Copy full SHA for 0a7baad

• Rename Beats::setBar to Beats::setDownBeat

  

  JaviVilarroig

  authored and

  daschuer

  committed
  04d89ea

  Copy full SHA for 04d89ea

• Rename Beats::setBar to Beats::setDownBeat and some adpaters

  

  JaviVilarroig

  authored and

  daschuer

  committed
  800adf6

  Copy full SHA for 800adf6

• Remove ascii art from Beats header

  

  JaviVilarroig

  authored and

  daschuer

  committed
  a7cf0d0

  Copy full SHA for a7cf0d0

• Replace BeatsPointer constructor by make_shared

  

  JaviVilarroig

  authored and

  daschuer

  committed
  865caf5

  Copy full SHA for 865caf5

• Adapt comment to clang-format

  

  JaviVilarroig

  authored and

  daschuer

  committed
  730abaa

  Copy full SHA for 730abaa

• Fix BeatsFactory method signatures to use references.

  

  JaviVilarroig

  authored and

  daschuer

  committed
  7f857a6

  Copy full SHA for 7f857a6

• Remove anonymous namespace from beats.h

  

  JaviVilarroig

  authored and

  daschuer

  committed
  9f1039d

  Copy full SHA for 9f1039d

• Remove spurious property from Beats

  

  JaviVilarroig

  authored and

  daschuer

  committed
  b3ecb4e

  Copy full SHA for b3ecb4e

• Fixes in BeatIterator

  Show description for 1485e8a
  

  JaviVilarroig

  authored and

  daschuer

  committed
  1485e8a

  Copy full SHA for 1485e8a

• Waveformrenderbeat to interact with beats using frames

  

  JaviVilarroig

  authored and

  daschuer

  committed
  58dbf80

  Copy full SHA for 58dbf80

• pre-commit configuration taken from master

  

  JaviVilarroig

  authored and

  daschuer

  committed
  49e3d09

  Copy full SHA for 49e3d09

• Small general fixes in BeatFactory.

  

  JaviVilarroig

  authored and

  daschuer

  committed
  c628235

  Copy full SHA for c628235

• Comments added to const_cas in BeatIterator

  

  JaviVilarroig

  authored and

  daschuer

  committed
  1b90cc3

  Copy full SHA for 1b90cc3

• Change name of method toByteArray to toProtobuff

  Show description for 3512947
  

  JaviVilarroig

  authored and

  daschuer

  committed
  3512947

  Copy full SHA for 3512947

• Fix in indentation

  

  JaviVilarroig

  authored and

  daschuer

  committed
  20cd34c

  Copy full SHA for 20cd34c

• Add comments to clearly mark temporary methods

  

  JaviVilarroig

  authored and

  daschuer

  committed
  d663f04

  Copy full SHA for d663f04

• BeatTrtanslateTest is now OK.

  Show description for cbdba12
  

  JaviVilarroig

  authored and

  daschuer

  committed
  cbdba12

  Copy full SHA for cbdba12

• Beats to use Bpm type

  Show description for 22d6d19
  

  JaviVilarroig

  authored and

  daschuer

  committed
  22d6d19

  Copy full SHA for 22d6d19

Commits on Jun 14, 2020

• Merge commit '18e6e1ed60af1fc9a39bda7302f48743085d8844' into bars_phrases_and_variable_BPM_in_beats_class3

  daschuer

  committed
  f81f1fd

  Copy full SHA for f81f1fd

• Fix segfault during tests

  daschuer

  committed
  b7c8f7b

  Copy full SHA for b7c8f7b

Commits on Jun 15, 2020

• fix some tests

  daschuer

  committed
  dde8b8f

  Copy full SHA for dde8b8f

• Use double precision for beat positions

  daschuer

  committed
  85c85f5

  Copy full SHA for 85c85f5

• Beats: Fix build

  Show description for 10715cd
  

  uklotzde

  authored and

  daschuer

  committed
  10715cd

  Copy full SHA for 10715cd

• Fix dependency ordering issues

  

  uklotzde

  authored and

  daschuer

  committed
  0ef78f3

  Copy full SHA for 0ef78f3

Commits on Jun 16, 2020

• beats.proto: rename beats to beats_per_bar

  

  hacksdump

  authored and

  uklotzde

  committed
  03afb56

  Copy full SHA for 03afb56

• beats.h: make class final

  

  hacksdump

  authored and

  uklotzde

  committed
  f432e59

  Copy full SHA for f432e59

• beats.h: remove version names from macros

  

  hacksdump

  authored and

  uklotzde

  committed
  0dc057d

  Copy full SHA for 0dc057d

• remove adapter for calculateBpm

  

  hacksdump

  authored and

  uklotzde

  committed
  51fdd42

  Copy full SHA for 51fdd42

• remove adapter for setGrid

  

  hacksdump

  authored and

  uklotzde

  committed
  0f8009b

  Copy full SHA for 0f8009b

• add frame class to avoid sample/frame ambiguity

  

  hacksdump

  authored and

  uklotzde

  committed
  2a4bffb

  Copy full SHA for 2a4bffb

• use single f in protobuf

  

  hacksdump

  authored and

  uklotzde

  committed
  56e9051

  Copy full SHA for 56e9051

• remove all adapters from main source

  

  hacksdump

  authored and

  uklotzde

  committed
  8e6625a

  Copy full SHA for 8e6625a

• adapt tests to frame class

  

  hacksdump

  authored and

  uklotzde

  committed
  ec62228

  Copy full SHA for ec62228

• remove residual beats subclasses and corresponding tests

  hacksdump

  committed
  91eb3d8

  Copy full SHA for 91eb3d8

• add channel count to beatstest

  hacksdump

  committed
  f9fd333

  Copy full SHA for f9fd333

• frame: add multiply and divide operations

  hacksdump

  committed
  9b962d7

  Copy full SHA for 9b962d7

• beats: use Frame vector in constructor

  hacksdump

  committed
  480f7f7

  Copy full SHA for 480f7f7

• beatfactory: write adapter to store beatgrid in beats

  hacksdump

  committed
  65a0d84

  Copy full SHA for 65a0d84

• beatfactory: use common serialized data for all beatgrid version

  hacksdump

  committed
  a49ebe0

  Copy full SHA for a49ebe0

• beats: remove unused code | rename proto

  hacksdump

  committed
  3e4664e

  Copy full SHA for 3e4664e

• beats: remove unused function getMaxBpm

  hacksdump

  committed
  a7b6d01

  Copy full SHA for a7b6d01

• beats: remove extraneous helper functions

  hacksdump

  committed
  919e1b9

  Copy full SHA for 919e1b9

• beats: remove derivable state variable

  hacksdump

  committed
  84d689c

  Copy full SHA for 84d689c

Commits on Jun 17, 2020

• beats: remove capability flags

  hacksdump

  committed
  fe7fd32

  Copy full SHA for fe7fd32

Commits on Jun 18, 2020

• beats:doc: describe source of data in constructor

  hacksdump

  committed
  8957a08

  Copy full SHA for 8957a08

• beats: remove optional sample rate parameter

  hacksdump

  committed
  e6b0383

  Copy full SHA for e6b0383

• bpm: remove redundant parantheses

  hacksdump

  committed
  b156cd5

  Copy full SHA for b156cd5

• Merge branch 'ambigous-sample-rate' into remove-beatmap-beatgrid

  hacksdump

  committed
  e67686f

  Copy full SHA for e67686f

• beats: simplify bpm scale function

  hacksdump

  committed
  eab8bb0

  Copy full SHA for eab8bb0

• timesignature: modify getters setters

  hacksdump

  committed
  43acd8f

  Copy full SHA for 43acd8f

• beats: remove test logic from main source

  hacksdump

  committed
  df01cce

  Copy full SHA for df01cce

• fix typo

  hacksdump

  committed
  bff9917

  Copy full SHA for bff9917

• beatutils: don't use framerate for audio

  hacksdump

  committed
  754ecfe

  Copy full SHA for 754ecfe

• beats: use double instead of rounding

  hacksdump

  committed
  4b515f2

  Copy full SHA for 4b515f2

• beats: define iterator

  hacksdump

  committed
  a1dc778

  Copy full SHA for a1dc778

• timesignature: move symmetrical operations outside class

  hacksdump

  committed
  e32a19c

  Copy full SHA for e32a19c

• remove redundant copying of member variable

  hacksdump

  committed
  454ba2c

  Copy full SHA for 454ba2c

Commits on Jun 19, 2020

• timesignature: use protobuf object to store signature

  hacksdump

  committed
  7eb655c

  Copy full SHA for 7eb655c

Commits on Jun 20, 2020

• beats: enable setBpm for all Beat detection modes

  hacksdump

  committed
  9c981fb

  Copy full SHA for 9c981fb

• frame: replace forward declaration with include

  hacksdump

  committed
  4329021

  Copy full SHA for 4329021

Commits on Jun 21, 2020

• frame.h refactor: use FramePos and FrameDiff_t

  hacksdump

  committed
  1356ccb

  Copy full SHA for 1356ccb

• beats: update outdated constructor documentation

  hacksdump

  committed
  9e04891

  Copy full SHA for 9e04891

• bpmcontrol: use parented pointers

  hacksdump

  committed
  43e16c1

  Copy full SHA for 43e16c1

• bpmcontrol: use unique pointers

  hacksdump

  committed
  f46860f

  Copy full SHA for f46860f

• beatiterator: pointer comparison and exclude end

  hacksdump

  committed
  ea4447a

  Copy full SHA for ea4447a

• change control name

  hacksdump

  committed
  33b6a4f

  Copy full SHA for 33b6a4f

• bpm: pass trivially copyable types by value

  hacksdump

  committed
  79ecd2a

  Copy full SHA for 79ecd2a

• bpm:use double for multiple and divide operations

  hacksdump

  committed
  c013576

  Copy full SHA for c013576

• beatiterator: remove destructor

  hacksdump

  committed
  0576be8

  Copy full SHA for 0576be8

• beats.proto: make fields required

  hacksdump

  committed
  cbc7977

  Copy full SHA for cbc7977

• beatutils: remove unnecessary const

  hacksdump

  committed
  d255364

  Copy full SHA for d255364

• beatutils: remove rounding for frame sample conversion

  hacksdump

  committed
  397b338

  Copy full SHA for 397b338

• beats: use correct range while returning iterator

  hacksdump

  committed
  a0ff6d9

  Copy full SHA for a0ff6d9

• beatstest: fix time signature test

  hacksdump

  committed
  cf75244

  Copy full SHA for cf75244

• beatstest: remove redundant state variable

  hacksdump

  committed
  074a921

  Copy full SHA for 074a921

• waveformrenderbeat: enable beat pen

  hacksdump

  committed
  136060b

  Copy full SHA for 136060b

• beatstest: fix NthBeatWhenNotOnBeat

  hacksdump

  committed
  86b834a

  Copy full SHA for 86b834a

Commits on Jun 22, 2020

• track: remove obsolete comments and debug info

  hacksdump

  committed
  cab96a2

  Copy full SHA for cab96a2

• bpmcontrol_test: fix BeatContext_BeatGrid

  hacksdump

  committed
  be68912

  Copy full SHA for be68912

Commits on Jun 24, 2020

• beatstest: fix BpmAround

  Show description for a9707f8
  hacksdump

  committed
  a9707f8

  Copy full SHA for a9707f8

• searchqueryparsertest: fuzzy comparison to fix tests

  hacksdump

  committed
  33bf4c9

  Copy full SHA for 33bf4c9

• bpm: pass qstring by reference

  hacksdump

  committed
  34c35d7

  Copy full SHA for 34c35d7

Commits on Jun 25, 2020

• beats: cleaner debug output

  hacksdump

  committed
  fe266d0

  Copy full SHA for fe266d0

• engine: use inline functions for frame conversion

  hacksdump

  committed
  4d8f2f2

  Copy full SHA for 4d8f2f2

• remove unnecessary frame quantization

  hacksdump

  committed
  0534db3

  Copy full SHA for 0534db3

• beats: rename method

  hacksdump

  committed
  915a671

  Copy full SHA for 915a671

• beats: remove copy to self

  hacksdump

  committed
  ca4425a

  Copy full SHA for ca4425a

• engine: update function to use FramePos instead of samples

  hacksdump

  committed
  540c749

  Copy full SHA for 540c749

Commits on Jun 26, 2020

• engine: refactor to use FramePos instead of sample

  hacksdump

  committed
  c00da80

  Copy full SHA for c00da80

• beats: don't delete beats on translate

  hacksdump

  committed
  5f0ce46

  Copy full SHA for 5f0ce46

• frame: use constant for invalid frame instead of -1

  hacksdump

  committed
  fa86f2a

  Copy full SHA for fa86f2a

• beatstranslatetest: fix SimpleTranslateMatch

  hacksdump

  committed
  38555e0

  Copy full SHA for 38555e0

• frame: use C++ style limits

  hacksdump

  committed
  7f89649

  Copy full SHA for 7f89649

Commits on Jun 28, 2020

• use inline functions for sample frame conversion

  hacksdump

  committed
  68a1949

  Copy full SHA for 68a1949

Commits on Jun 29, 2020

• fix wrong assignment to beats

  hacksdump

  committed
  c19d2f2

  Copy full SHA for c19d2f2

• loopingcontrol: use inline functions for sample frame conversion

  hacksdump

  committed
  55d7784

  Copy full SHA for 55d7784

• Merge branch 'master' into remove-beatmap-beatgrid

  hacksdump

  committed
  1fff80c

  Copy full SHA for 1fff80c

Commits on Jun 30, 2020

• loopingcontroltest: beat size within track duration

  hacksdump

  committed
  4f28348

  Copy full SHA for 4f28348

• use correct epsilon for finding nearby beat

  hacksdump

  committed
  8506d0b

  Copy full SHA for 8506d0b

• fix enginesynctest failing due to typo

  hacksdump

  committed
  71bf183

  Copy full SHA for 71bf183

• fix searchqueryparser test by reducing double precision

  hacksdump

  committed
  3933e76

  Copy full SHA for 3933e76

Commits on Jul 1, 2020

• remove unused functions

  hacksdump

  committed
  85e75c9

  Copy full SHA for 85e75c9

Commits on Jul 2, 2020

• remove unnecesary debug function

  hacksdump

  committed
  425c7fd

  Copy full SHA for 425c7fd

• searchquery: improve comment on precision downgrading

  hacksdump

  committed
  2ca2be4

  Copy full SHA for 2ca2be4

• beats: use namespaced constants

  hacksdump

  committed
  0710437

  Copy full SHA for 0710437

• factor out frame sample adapter functions

  hacksdump

  committed
  006cd74

  Copy full SHA for 006cd74

• loopingcontol: replace wrong variable

  hacksdump

  committed
  cd80c28

  Copy full SHA for cd80c28

• move frameadapter to util

  hacksdump

  committed
  bcd32c1

  Copy full SHA for bcd32c1

• use frameadapter in track

  hacksdump

  committed
  a7a7edd

  Copy full SHA for a7a7edd

• fix scons build

  hacksdump

  committed
  6268b30

  Copy full SHA for 6268b30

• frameadapter: change comment

  hacksdump

  committed
  b2a9bcf

  Copy full SHA for b2a9bcf

• beats: temporary dirty workaround for copy constructor

  hacksdump

  committed
  792c682

  Copy full SHA for 792c682

• beatsproto: make all fields optional

  hacksdump

  committed
  8452657

  Copy full SHA for 8452657

Commits on Jul 7, 2020

• create new internal beats class independent of QObject

  hacksdump

  committed
  8134eae

  Copy full SHA for 8134eae

• simplify copy constructor

  hacksdump

  committed
  a60beee

  Copy full SHA for a60beee

• beats: move findNthBeat to plain class

  hacksdump

  committed
  9a08d05

  Copy full SHA for 9a08d05

• beats: move more code to plain class

  hacksdump

  committed
  13538d3

  Copy full SHA for 13538d3

Commits on Jul 8, 2020

• beats: move scale functions to plain class

  hacksdump

  committed
  0a5fba3

  Copy full SHA for 0a5fba3

• beats: move all implementation to plain class

  hacksdump

  committed
  274c9fa

  Copy full SHA for 274c9fa

Commits on Jul 11, 2020

• beats: use function to calculate beat length

  hacksdump

  committed
  49686eb

  Copy full SHA for 49686eb

Commits on Jul 12, 2020

• beats: add back old protobuf types for backwards compatibility

  hacksdump

  committed
  eb3b6c9

  Copy full SHA for eb3b6c9

Commits on Jul 13, 2020

• beats: add version to distinguish from earlier versions

  hacksdump

  committed
  d3b7a5a

  Copy full SHA for d3b7a5a

Commits on Jul 14, 2020

• beats: add migration code

  hacksdump

  committed
  79f5b2a

  Copy full SHA for 79f5b2a

• merge from master and resolve conflicts

  hacksdump

  committed
  6a52cab

  Copy full SHA for 6a52cab

• update comments

  hacksdump

  committed
  abf9694

  Copy full SHA for abf9694

• revert all UI changes

  hacksdump

  committed
  7302922

  Copy full SHA for 7302922

Commits on Jul 16, 2020

• use beat indices as marker basis

  hacksdump

  committed
  77c8d82

  Copy full SHA for 77c8d82

• change section message

  hacksdump

  committed
  1e2565a

  Copy full SHA for 1e2565a

• remove redundant ctor initializer

  hacksdump

  committed
  cc0d8ef

  Copy full SHA for cc0d8ef

• remove legacy name from comment

  hacksdump

  committed
  de26dd4

  Copy full SHA for de26dd4

• add debug asserts

  hacksdump

  committed
  e76bfc3

  Copy full SHA for e76bfc3

• add placeholder parameters

  hacksdump

  committed
  1967c0f

  Copy full SHA for 1967c0f