allow skins to style sidebar context menus

[ronso0]

c++ changes to complete #2337 Skins :: adjust styles of skin context menus, tooltip for the sidebar right-click menu which was previously not stylable via qss because it was created without a parent widget.
Now sidebar widget is passed to each library feature (that has a context menu) and used there as parent widget for creating the context menus.

I also added a right-click action for paths in In 'Computer' tree that are in QuickLinks. This allows to remove those paths from Quick Links easily when they were added accidentially.

Lesson learned:

if within each feature the context menu is parented to QApplication::focusWidget() (which would be WLibrarySidebar as well) some issues arise:

• menu pops up at wrong place (cursorPos relative to widget 0,0 + global cursorPos)
• menu is cropped by parent widget's geometry
• menu won't close on selection or when clicking any menu item or outside the menu

ToDo

• test with iTunes feature
• test with Traktor feature
• test with Banshee feature
• test with Rhythmbox feature
• test after skin change / reload

Before merge

• remove debug output
• remove example style from skins

[ronso0]

Do I need to implement this?

[ronso0]

Woohoo, done.
I rebased and it's compact now and easy to review.
Please test.

[daschuer]

Than you.
I can test this on Ubuntu.
So you think we need test for the other targets?

[ronso0]

I can test this on Ubuntu.
So you think we need test for the other targets?

Sure, testing on Win / MacOS dosn't harm. Though I don't see a reason the platform would make a difference here.

[ronso0]

cleaned up & rebased.
Nice to see how simple this actually was in the first place... 🤠

For completeness, this needs to be tested with iTunes and Traktor features.

[daschuer]

This works with iTunes and Traktor.

Was the green menu background intended or is this a debug leftover?

[ronso0]

Was the green menu background intended or is this a debug leftover?

the green menu is for testing only.

Before merge
[x] remove debug output
[ ] remove example style from skins

Let me know when you consider this ready for merge, and I'll remove it.

[daschuer]

GitHub editor has eaten the template type.
It should be:

QPointer<WLibrarySidebar> m_pSidebarWidget;

[ronso0]

error: field ‘m_pSidebarWidget’ has incomplete type ‘QPointer<WLibrarySidebar>’
     QPointer<WLibrarySidebar> m_pSidebarWidget;

had to #include QPointer and move #include wlibrarysidebar.h to the header files

[uklotzde]

You can use a forward declaration for WLibrarySidebar in the header file to reduce compile time dependencies. This is the preferred way for classes within the project.

[daschuer]

The CI issues are only time outs. Is this ready for merge now?

Please avoid in future to rebase pending code PRs, because that requires a full code review, while otherwise only the latest changes needs to be reviewed.
Rebasing makes sens to clean up the history from already replaced bitmaps.
So it is best to discuss it with the reviewer if unsure.

[ronso0]

Alright. I rebased because now it's only one commit that's 'critical', and that's very compact and repetetive for the internal library features.
Thanks for your help!

[ronso0]

yes, ready for merge!

[daschuer]

Thank you for keeping care of all these details :-)
LGTM

[ronso0]

@daschuer Whoopsy,.. in pleasant anticipation I missed to remove the orange/green example styles.
#2349 should be merged asap!