Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use clang-tidy lint readability-identifier-naming #13642

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: use clang-tidy lint readability-identifier-naming #13642

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3caf06a
feat: use clang-tidy lint readability-identifier-naming
Swiftb0y Sep 9, 2024
e9587bb
generator compile_commands.json unconditionally (for clang-tidy)
Swiftb0y Sep 10, 2024
c3da7b1
add clang-tidy pre-commit hook
Swiftb0y Sep 10, 2024
dcf39f2
remove cmake clang-tidy code
Swiftb0y Sep 10, 2024
7fc3362
remove clang-tidy CI as the diff is now checked pre-commit
Swiftb0y Sep 10, 2024
4abc2b2
remove outdated workaround
Swiftb0y Sep 10, 2024
ce7879d
fixup! add clang-tidy pre-commit hook
Swiftb0y Sep 10, 2024
2369daa
fixup! add clang-tidy pre-commit hook
Swiftb0y Sep 10, 2024
8cf4b52
fixup! fixup! add clang-tidy pre-commit hook
Swiftb0y Sep 10, 2024
79d9a99
fixup! fixup! fixup! add clang-tidy pre-commit hook
Swiftb0y Sep 10, 2024
3ea3dcc
fixup! remove cmake clang-tidy code
Swiftb0y Sep 10, 2024
64a087a
fixup! add clang-tidy pre-commit hook
Swiftb0y Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! add clang-tidy pre-commit hook
  • Loading branch information
@Swiftb0y
Swiftb0y committed Sep 10, 2024
commit 64a087a1110adf62ee91da71dba2b25e5c86f8bc
7 changes: 2 additions & 5 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ jobs:
pre-commit:
name: Detecting code style issues
runs-on: ubuntu-latest
# The Dockerfile for this container can be found at:
# https://github.com/Holzhaus/mixxx-ci-docker
container: holzhaus/mixxx-ci:20220612-qt6
steps:
- name: "Check out repository"
uses: actions/checkout@v4.1.7
Expand All @@ -36,10 +33,10 @@ jobs:
run: |
git config --global --add safe.directory "${GITHUB_WORKSPACE}"
git config --global --list

- name: Install build dependencies
run: tools/debian_buildenv.sh setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quite costly operation IMO - how do you feel about updating the Docker image instead? Note that would could also make the container in #14018 pushed in GHCR and reuse it in our CI? It may actually be quite good as we could use it build (Ubuntu) as well and a save a significant amount of bandwidth/resource consumption

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I agree. this was just a quick and dirty PoC that has stalled now (because of issues like these). Updating the docker would def. be preferred.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mixxxdj/developers any objection in me extending the scope of #14018 and publish devcontainer in Mixxx GHCR repo?

- name: "Create build directory"
run: mkdir build

- name: "Create compile_commands.json"
# this is required for clang-tidy to work
run: |
Expand Down
Loading