Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libkeyfinder: Fix offline build #11716

Merged
merged 1 commit into from
Jul 7, 2023
Merged

libkeyfinder: Fix offline build #11716

merged 1 commit into from
Jul 7, 2023

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Jul 6, 2023 •
edited
Loading

It's broken since #11146.

@github-actions github-actions bot added the build label Jul 6, 2023
@daschuer daschuer changed the base branch from 2.4 to 2.3 July 7, 2023 05:50
@daschuer
Copy link
Member

daschuer commented Jul 7, 2023

This is also an issue in the 2.3 branch. Can you rebase it?

@daschuer daschuer self-requested a review July 7, 2023 05:51
daschuer
daschuer requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

daschuer
daschuer approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit d027faa into mixxxdj:2.3 Jul 7, 2023
@uklotzde uklotzde deleted the libkeyfinder branch July 23, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer