Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop browse thread before deleting the library #11593

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Stop browse thread before deleting the library #11593

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edd7f0d
Stop browse thread before deleting the library
daschuer May 24, 2023
6642b53
Explain why resetting the m_pBrowseThread stops the thread
daschuer May 27, 2023
f33dcc7
Rename releaseBrowseThread()
daschuer Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explain why resetting the m_pBrowseThread stops the thread
  • Loading branch information
@daschuer
daschuer authored May 27, 2023
commit 6642b533557cad74a7d284c3ae2268aaa4173292
3 changes: 3 additions & 0 deletions src/library/browse/browsetablemodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,5 +475,8 @@ QAbstractItemDelegate* BrowseTableModel::delegateForColumn(const int i, QObject*
}

void BrowseTableModel::stopBrowseThread() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this function is inappropriate as the comment tells. It doesn't stop the browse thread, it just drops one of multiple references.

-> resetBrowseThread() or releaseBrowseThread()?

// The shared browse thread is actually stopped in the desctuctor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

// if this is the last reference. All references must be reset before
// the library is destructed.
m_pBrowseThread.reset();
}