Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EQ and waveforms by enabling infinite math in fidlib #11501

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Fix EQ and waveforms by enabling infinite math in fidlib #11501

merged 1 commit into from
Apr 21, 2023

Conversation

daschuer
Copy link
Member

See #11483

I will prepare a test in a separate PR, because I am not able to fail it here.

@github-actions github-actions bot added the build label Apr 21, 2023
uklotzde
uklotzde approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I independently tried the same fix and can confirm that this fixes the issues. Scaring, that this was wrong all the time.

Swiftb0y
Swiftb0y approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also confirm that it fixes the issue. I have confirmed this using both your test from #11502 and manually generating and inspecting a tracks waveform.

@Swiftb0y Swiftb0y merged commit ea857e5 into mixxxdj:2.3 Apr 21, 2023
@Swiftb0y Swiftb0y mentioned this pull request Apr 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @uklotzde @Swiftb0y