Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64: Fix -Wasm-operand-widths #11490

Merged
merged 1 commit into from
Apr 17, 2023
Merged

aarch64: Fix -Wasm-operand-widths #11490

merged 1 commit into from
Apr 17, 2023

Conversation

uklotzde
Copy link
Contributor

Build fails on Clang 16 which is needed as a (temporary) workaround for #11483.

Broken build: https://koji.rpmfusion.org/kojifiles/work/tasks/4069/594069/build.log
Fixed build: https://koji.rpmfusion.org/kojifiles/work/tasks/4081/594081/build.log

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Swiftb0y Swiftb0y merged commit 0df6ed9 into mixxxdj:2.3 Apr 17, 2023
@daschuer
Copy link
Member

FPCR is actually 64 bits on aarch64:
https://developer.arm.com/documentation/ddi0601/2020-12/AArch64-Registers/FPCR--Floating-point-Control-Register?lang=en#fieldset_0-63_27

So I think this is a permanent fix. Thank you.

@uklotzde
Copy link
Contributor Author

FPCR is actually 64 bits on aarch64: https://developer.arm.com/documentation/ddi0601/2020-12/AArch64-Registers/FPCR--Floating-point-Control-Register?lang=en#fieldset_0-63_27

So I think this is a permanent fix. Thank you.

Sure, this fix is permanent. But switching the compiler to Clang on RPMFusion might be temporary.

@uklotzde uklotzde deleted the aarch64-asm-operand-widths branch April 17, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants