-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use always non GL VU-Meters in case no sufficiant GL version is available #11288
Conversation
I tested this /w and /wo --safemode for 2.3 branch and this PR. The test showed, that this VU-Meter is broken for --safemode in 2.3 branch, but not for this PR. I noticed the following unrelated issue: If I use --safemode, OpenGL waveforms are disabled and only the non-OpenGL waveforms are listed in the preferences, as supposed to be. But none of these non-OpenGL waveforms are rendered in Safemode, if I select them, I see just a black area. |
Code LGTM |
if (!CmdlineArgs::Instance().getUseVuMeterGL() | | ||
(!pWaveformWidgetFactory->isOpenGlAvailable() && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo which results in different semantics... Would probably have been caught by -Wconversion
if (!CmdlineArgs::Instance().getUseVuMeterGL() | | |
(!pWaveformWidgetFactory->isOpenGlAvailable() && | |
if (!CmdlineArgs::Instance().getUseVuMeterGL() || | |
(!pWaveformWidgetFactory->isOpenGlAvailable() && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create a PR to fix this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is: #11292
This fixes #11286 a regression since #10893