Code

JACK buffer size fix.#11121

Code

Merged

JoergAtGithub merged 21 commits intomixxxdj:2.3mixxxdj/mixxx:2.3from daschuer:jack-api-check-rebasedaschuer/mixxx:jack-api-check-rebaseCopy head branch name to clipboardFeb 4, 2023

+364-297

Commits

Commits on Dec 6, 2022

• Fix condition in JACK backend check

  Show description for c2b1af8
  robbert-vdh

  committed
  c2b1af8

  Copy full SHA for c2b1af8

• Replace m_framesPerBuffer uses with runtime size

  Show description for 82c7f71
  robbert-vdh

  committed
  82c7f71

  Copy full SHA for 82c7f71

• Use std::unique_ptr for FIFOs in PortAudio backend

  Show description for fefbfd2
  robbert-vdh

  committed
  fefbfd2

  Copy full SHA for fefbfd2

Commits on Dec 8, 2022

• Remove unused getProcessingLatency() function

  

  robbert-vdh

  authored and

  daschuer

  committed
  cfeffa7

  Copy full SHA for cfeffa7

• renamed m_framesPerBuffer to m_configFramesPerBuffer

  Show description for 1451803
  daschuer

  committed
  1451803

  Copy full SHA for 1451803

• Improve the comment that explains paFramesPerBufferUnspecified

  daschuer

  committed
  b1b14b1

  Copy full SHA for b1b14b1

• Don't use the m_configFramesPerBuffe and improve debug output and comments.

  daschuer

  committed
  8f97592

  Copy full SHA for 8f97592

• dispose m_iBufferSize and use always the callback value as parameter

  Show description for 4c1eb24
  daschuer

  committed
  4c1eb24

  Copy full SHA for 4c1eb24

• Always use the real framesPerBuffer value received via the callback

  Show description for e52de39
  daschuer

  committed
  e52de39

  Copy full SHA for e52de39

• Deduplicate code in VisualPlayPosition

  daschuer

  committed
  75d0e29

  Copy full SHA for 75d0e29

• Apply a better offset limit in VisualPlayposition

  daschuer

  committed
  f1bc670

  Copy full SHA for f1bc670

• Dispose audio_buffer_size and use directly the callback parameter

  daschuer

  committed
  096089d

  Copy full SHA for 096089d

• Use MAX_BUFFER_LEN for all non clock reference devices in case of JACK.

  daschuer

  committed
  6d24c26

  Copy full SHA for 6d24c26

• Don't allow setting device sync and network clock with the JACK API

  daschuer

  committed
  705e097

  Copy full SHA for 705e097

• Avoid implicit conversion from double to bool

  daschuer

  committed
  e15cda3

  Copy full SHA for e15cda3

• Improve comment about vectorization

  daschuer

  committed
  b48e06d

  Copy full SHA for b48e06d

• Improve comments and debug output

  daschuer

  committed
  185a681

  Copy full SHA for 185a681

• check channel count for > 0 instead of implicit bool conversion

  daschuer

  committed
  44fa755

  Copy full SHA for 44fa755

Commits on Dec 9, 2022

• Remove unused variable

  daschuer

  committed
  32379a6

  Copy full SHA for 32379a6

Commits on Dec 16, 2022

• Fix jackApiUsed() implementation

  daschuer

  committed
  31ba28e

  Copy full SHA for 31ba28e

Commits on Jan 25, 2023

• Use the correct term frames per period

  daschuer

  authored
  f49bf12

  Copy full SHA for f49bf12