-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automatic QML type registration for Qt 6.3.x #10928
Conversation
Yikes, now we have a mismatch between CI qmlformat and local qmlformat because it's a system depedency that does not allow pinning :( |
This is a workaround for [QTBUG-104373], which broke automatic type registration of C++ QML types if the QML module version starts with `0`. As a workaround, we simply increase the version from `0.1` to `1.0`. Fixes mixxxdj#10854. [QTBUG-104373]: https://bugreports.qt.io/browse/QTBUG-104373
063f73f
to
b6e7604
Compare
I removed the formatting changes for now, I'll take care of that in a separate PR. EDIT: See #10929. |
Fix confirmed! It actually works with library and playback and all! |
Shall we merge then? |
Sounds good to me. But I wonder how you have been able to commit: When I try to commit qml files (e.g. main.qml without any actual changes) qmllint fails:
Doesn't this happen to you? |
I see I can run qmllint successfully with these arguments:
|
Any suggestions how to deal with this? BTW, I notice that 6.3.2 qmlformat does some weird stuff, like this:
|
We have a policy of not merging our own PRs, so this was just a small hint to the other core team members to have a look 😉
qmllint does not complain on my machine. If it doesn't work for you, you probably have a different qmllint version installed.
Let's discuss this on #10929. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Waiting for my local build so I can confirm with a smoke test. Thanks.
fyi I unwatched the repo. So please @ me or request a review if you need my involvement. |
works with Qt 6.3.1 ✔️ |
Thanks! |
Works around QTBUG-104373.