Library Scanner: sort files before adding #10919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative aproach would be, to add a date(datetime_added) column to the temporary view and use this for sorting, but this would likely require larger changes. |
daschuer
requested changes
Sep 27, 2022
Sort files in each scanned directory alphabetically before adding. This causes folders which contain track numbered files to be added in it's natural order, so sorting after date added also sorts for track numbers. Since the tracks will have slightly different timestamps, using a second sorting does not work.
poelzi
force-pushed
the
sorted-index
branch
from
e68fb68 to
11f0861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort files in each scanned directory alphabetically before adding. This causes folders which contain track numbered files to be added in it's natural order, so sorting after date added also sorts for track numbers. Since the tracks will have slightly different timestamps, using a second sorting does not work.