Vinyl Control not engaging

[djquartz]

Bug Description

I setup Mixxx on my Dell 5290 running Windows 10 and found that the Vinyl Control is not engaging with my Rane One setup.

I tried it with 2.4.2, 2.4.5 and 2.4.6_alpha and they all do the same thing.

I double checked the turntable input volume and adjusted it accordingly.

There is a good noisemap signal showing on the scopes. When I enable passthrough I can hear a clean noisemap signal from the vinyl playing.

What happens is when I click the Vinyl Contol button it plays the track for a a seconds in internal mode and then stops.

The vinyl control is not responding to the control vinyl at all even though there is a signal coming through.

When I tested on MacOS, when I clicked the Vinyl Control button it would immediately enable vinyl control and would work.

Version

2.4.2 - 2.6-alpha

OS

Windows 10

[Swiftb0y]

Hey there, thank you for filling your issue. In order to get to the bottom of this. We would like to inspect your log file. Please use our guide to find it and then upload it here and we'll see if we can spot anything in the log. Thank you.

[djquartz]

Thank you for responding, I'll have to get the info tonight but I will submit asap.

[djquartz]

Please see the attached log file.
mixxx.log

[Swiftb0y]

Thanks. I do spot an odd line in there:

20:42:41.890 Debug [VinylControlProcessor 1] Xwax Vinyl control starting with a sample rate of: 0 Hz

Can you share your mixxx.cfg? It should reside in the same directory as the log files.

[djquartz]

Please see attached

mixxx.zip

[Swiftb0y]

Thanks. It seems this has been broken for some time now for new installs and not discovered until now. Does this match your setup? Has mixxx been installed and run previously on the MacOS setup you mentioned?

As a quick and dirty workaround, you can add this entry into your mixxx.cfg manually with a text editor:

[Soundcard]
Samplerate 48000

The exact number depends on your audio samplerate. Its likely 41000 or 48000, but rather than guessing just look it up in Preferences > Sound Hardware > Sample Rate.

[ronso0]

[Soundcard]
Samplerate 48000

Where is that preference supposed to be read?
Do you mean to verify soundconfig.xml contains samplerate="48000"?

[Swiftb0y]

Where is that preference supposed to be read?

mixxx/src/vinylcontrol/vinylcontrolxwax.cpp

Lines 139 to 142 in d18764a

	const auto sampleRate = mixxx::audio::SampleRate(
	m_pConfig->getValueString(ConfigKey("[Soundcard]", "Samplerate"))
	.toUInt());

Since that is not in the user config it defaults to zero and thus "Xwax Vinyl control starting with a sample rate of: 0 Hz" is printed.

There is some explicit code that copies the samplerate from the soundconfig to the user config:

mixxx/src/soundio/soundmanager.cpp

Lines 567 to 572 in 16a9940

	// certain parts of mixxx rely on this being here, for the time being, just
	// letting those be -- bkgood
	// Do this first so vinyl control gets the right samplerate -- Owen W.
	m_pConfig->set(ConfigKey("[Soundcard]", "Samplerate"),
	ConfigValue(static_cast<int>(m_config.getSampleRate().value())));

(which has been dropped in main likely mistakenly as part of #13649).

All in all, the Vinyl code is in terrible shape...

[djquartz]

I will give the manual entry a try to see if it fixes things. The sample rate the interface uses on the Rane One is 48000.

[Swiftb0y]

Great. then the snippet I posted should work as is. You can simply append it to the mixxx.cfg.

[djquartz]

Yes adding the sample rate fixed the issue. I also noticed I have to tap the Vinyl button a few times for it to turn on.

[Swiftb0y]

Yeah... as I said, not in the greatest of shape... I have a turntable setup at home, so I might be able to give this some love in a future version. As of right now, I'm fairly certain its broken in main/2.6...