loop_in & loop_out at same postion should not create a loop

[mixxxbot]

Reported by: ronso0
Date: 2021-11-09T22:57:44Z
Status: Confirmed
Importance: Undecided
Launchpad Issue: lp1950392
Tags: looping

---

I discovered this by chance:

• set loop_in
  (don't change play position)
• set loop_out
  = loop is created and activated
• hit Play
  = waveform 'vibrates'

IMO when setting the loop_out in the same position Mixxx should refuse to create a loop.

check for loop_in < loop_out here
https://github.com/mixxxdj/mixxx/blob/441181a1338bc00be45cde8bf772bca844bbbd95/src/engine/controls/loopingcontrol.cpp#L844

[mixxxbot]

Commented by: daschuer
Date: 2021-11-09T23:20:35Z

---

I think we need to replace < with <= here: 

mixxx/src/engine/controls/loopingcontrol.cpp

Line 765 in 441181a

if (!loopInfo.startPosition.isValid() || position < loopInfo.startPosition) {

It is a vibrating loop because of the quantize effect of the engine. Loops can't be shorter than a buffer size. So maybe we should take this into account here as well.

[mixxxbot]

Commented by: ronso0
Date: 2022-06-14T22:35:11Z

---

It seems the loop is already grown to have playable span.