S4MK3: add support for Stem, rework hotcues and add beatjumps #703

acolombier · 2024-12-06T00:30:30Z

Related to ~~mixxxdj/mixxx#13653~~ mixxxdj/mixxx#15216

https://deploy-preview-703--mixxx-manual.netlify.app/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.html

acolombier · 2024-12-06T00:31:06Z

@ywwg I would really appreciate a review if you can! :)

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst

ronso0 · 2024-12-08T20:27:07Z

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst

 2. **Grid**: The track's detected beats will be move forward or backward on the waveform.
 3. **BPM**: The track's detected BPM will be increased or decreased.
 4. **Keyboard**: The keyboard's keys displayed on pads get moved up or down to display higher or lower keynotes.
+5. **Hotcue color**: When selecting a hotcue, the move encoder can be used to change the selected color.


While the hotcue button is pressed?

Oh, it's explained below..

IMO it would be better to explain the modes first then refer to them in each component section.

Are you suggesting to swap the list and table

ronso0 · 2024-12-08T20:36:07Z

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst


-============================================================================================== =========================================== ================================================================================================================= ===================================================================================== ================================================================================================================================================================================================================
+============================================================================================== =========================================== ================================================================================================================= ===================================================================================== ======================================================================================================================================================================================================================================
 Setting                                                                                        Variable value                              Default                                                                                                           Range                                                                                 Description


My experience with this table:

the content is very wide and I have to scroll horizontally to check the description for example

I don't need the Variable value column. If I'd be interested, I'd look at the settings in the js file
-> this would reduce the table width

in the Default column we may remove the the prefix (LEDColors etc.) and just show the values
-> this would reduce the table width

Since 2.4 is EOL, I'm tempted to remove a lot actually, since with the SettingsAPI, you shouldn't have to edit the file, except if you are hacking around. Wdyt?

ronso0 · 2025-03-10T12:21:35Z

Wanted to take look but Netlify fails with

1:38:04 AM: Failed during stage 'Install dependencies': dependency_installation script returned non-zero exit code: 1
1:38:04 AM: mise python@3.*      install
1:38:04 AM: mise WARN  no precompiled python found for 3.*, force mise to use a precompiled version with `mise settings set python.compile false`
1:38:04 AM: mise python@3.*      python-build
1:38:04 AM: python-build: definition not found: 3.*

acolombier · 2025-03-10T13:46:20Z

Fixed @ronso0 - my branch was quite out of date it turns out

acolombier · 2025-08-18T17:12:20Z

I have rebased and reword that PR to exclude the screen bits (4c9c600), which I will add in a follow up PR against 2.7. Does that sound all good?

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst

ywwg

comment only

ywwg · 2025-08-21T18:56:49Z

(can't find a way to just dismiss a change request)

acolombier · 2025-08-21T19:02:14Z

(can't find a way to just dismiss a change request)

For the future, it's hidden at the bottom, near the merge button :)

[..] address this a separate issue?

Do you want to create an issue and perhaps capture how you would like it to render? Or do you have time/interest in looking into this?

ywwg · 2025-08-22T14:29:51Z

Mostly I just want a narrative howto for how to work with effects like you have for the motor and jogwheel section.

ywwg · 2025-08-22T14:32:32Z

#788

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst

SamWhited · 2025-09-14T11:04:14Z

The screens use a USB Bulk transfer. Mixxx doesn’t support rendering content for external screens yet

Still says this in the intro section, but I think this PR is for post screen support.

acolombier · 2025-09-14T12:29:33Z

Good catch! This should indeed have been moved in the other manual PR.

I have taken the freedom to squash the fixup already, so if everything is looking fine now, we can merge it as the mapping changes have been merged already!

ronso0 · 2025-09-14T16:00:46Z

Are the changes other than the rst file relevant for this PR, or did they slip in by accident during rebase?

The netlify preview is outdated and the HTML runner skipped -- because of these changes?

acolombier · 2025-09-14T19:39:01Z

Yeah, 93eee16 is not related to this PR directly. I can move it to another PR if you would prefer!

acolombier · 2025-09-14T23:03:48Z

The netlify preview is outdated and the HTML runner skipped -- because of these changes?

Spent sometimes looking into this - the HTML job is expected to be skipped, and by the look of it, the Netlify deploy is orchestrated remotely, likely with a webhook, but I don't have access to this repo's settings, or the Netlify project.

@mixxxdj/admins can you have a look or grant me the permission to do so?

ronso0 · 2025-09-14T23:32:34Z

Yeah, 93eee16 is not related to this PR directly. I can move it to another PR if you would prefer!

Yup, that'd be better.
Else this LGTM and ready for merge.

Thanks for looking into the netlify issue!

ywwg · 2025-09-15T14:09:01Z

I should have time to do one last test today and I promise I will only look at the specific functionality being added :)

ywwg · 2025-09-22T18:21:39Z

Sorry for the delay. I hope to get to this soon

ronso0 · 2025-09-22T20:26:46Z

This mapping is out in 2.6beta and the docu doesn't match anymore.
Let's just merge and fix potential issues as well as improve formatting/fx handling in a followup?

ywwg · 2025-09-23T21:28:22Z

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst

+--------------+-----------------------------------------------------------------------------+
+| Keyboard     | This mode is enabled while :hwlabel:`SHIFT` + :hwlabel:`STEM` is held down  |
+--------------+-----------------------------------------------------------------------------+
+| Hotcue color | This mode is enabled while :hwlabel:`HOTCUES` is held down                  |


this functionality should be merged in, right? This is not working for me.

(I am using 2.6)

Press both HOTCUE and a hotcue, then turn left encoder.
Doesn't work?

Hotcue color controls have been added in 2.4 or even earlier so this should work.

yeah, nothing happens. I'll triple-check that my S4 is using the right mapping.

Hmm.. I can test the mapping (mixxxdj/mixxx#15216) tomorrow.

Btw it would be cool if we could use the last used hotcue, instead of having to press two buttons.

I think just setting the selected pad value regardless of mode would at least fix the immediate discoverability issue and wouldn't introduce any side effects

I'm not sure that would work as it will have a side effect with the left encoder itself - if you go with this approach, when you would use it, it would change the color of the last triggered hotcue. Equally, it would require to trigger the hotcue which would impact the playback (currently you can edit the color why being live)

you could clear the selected hotcue button value when the hotcue selector button is released.

at the very least, let's clarify the docs to say that the user has to hold the hotcue button down for a period of time before pressing the hotcue pad.

Do we need to tie this edit mode to long press? it looks like short press doesn't do anything other than change the screen. Changing the page only triggers on short release.

Pick whatever solution you like, but for now, let's at least make the docs more clear so that others don't trip over the same issue.

Yeah I think we could use short press too tbh.

Do you have any rewording suggestions to make the current instructions clearer? I can try to update when I'm back otherwise.

ronso0 · 2025-09-24T13:36:59Z

I don't find info on how to focus an effect.
(it's Shift + long-press effect)

acolombier · 2025-09-24T16:36:56Z

I don't find info on how to focus an effect. (it's Shift + long-press effect)

Ah good catch! I'm going to be away from keyboard for the next few days, so feel free to push a change if you would want to unblock the 2.6 out of sync doc, otherwise I will have a look when I get back, somewhere in the first half of October

ywwg · 2025-09-25T13:13:17Z

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst

+--------------+-----------------------------------------------------------------------------+
+| Keyboard     | This mode is enabled while :hwlabel:`SHIFT` + :hwlabel:`STEM` is held down  |
+--------------+-----------------------------------------------------------------------------+
+| Hotcue color | This mode is enabled while :hwlabel:`HOTCUES` is held down                  |


ywwg · 2025-09-25T13:14:06Z

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst

 2. **Grid**: The track's detected beats will be move forward or backward on the waveform.
 3. **BPM**: The track's detected BPM will be increased or decreased.
 4. **Keyboard**: The keyboard's keys displayed on pads get moved up or down to display higher or lower keynotes.
+5. **Hotcue color**: When holding both :hwlabel:`HOTCUES` and a hotcue, the move encoder can be used to change the selected color.


Suggested change

5. **Hotcue color**: When holding both :hwlabel:`HOTCUES` and a hotcue, the move encoder can be used to change the selected color.

5. **Hotcue color**: When first holding :hwlabel:`HOTCUES`, then tapping a specific hotcue, the move encoder can be used to change the selected color.

ronso0 · 2025-09-27T20:17:47Z

I have this commit 162b5e3 / https://github.com/acolombier/mixxx-manual/pull/1to simplify the fx section a bit, ie. remove redundancy.

Btw these tables are a PITA to edit, wasn't there a more user-friendly way?

SamWhited · 2025-09-27T20:19:35Z

Btw these tables are a PITA to edit, wasn't there a more user-friendly way?

I always use CSV Tables, ugly, but way easier to edit.

ronso0 · 2025-09-27T20:34:00Z

Yeah, I just discovered that, too, but with csv there's no row-span/col-span.

acolombier mentioned this pull request Dec 6, 2024

S4 Mk3 screen support mixxxdj/mixxx#13653

Open

4 tasks

ronso0 reviewed Dec 8, 2024

View reviewed changes

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated Show resolved Hide resolved

ronso0 reviewed Dec 8, 2024

View reviewed changes

acolombier force-pushed the feat/s4-mk3-screens branch from 0a13166 to 4551cbc Compare March 10, 2025 13:40

acolombier mentioned this pull request Aug 18, 2025

S4 MK3 improvements mixxxdj/mixxx#15216

Merged

acolombier changed the title ~~S4MK3: add support for screens~~ S4MK3: add support for Stem, rework hotcues and add betajump Aug 18, 2025

acolombier changed the title ~~S4MK3: add support for Stem, rework hotcues and add betajump~~ S4MK3: add support for Stem, rework hotcues and add beatjumps Aug 18, 2025

acolombier changed the base branch from main to 2.6 August 18, 2025 17:10

acolombier requested review from ronso0 and ywwg August 18, 2025 17:11

ywwg requested changes Aug 20, 2025

View reviewed changes

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Show resolved Hide resolved

ywwg reviewed Aug 21, 2025

View reviewed changes

ywwg approved these changes Aug 21, 2025

View reviewed changes

ronso0 reviewed Aug 22, 2025

View reviewed changes

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated Show resolved Hide resolved

ronso0 reviewed Aug 22, 2025

View reviewed changes

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated Show resolved Hide resolved

ronso0 reviewed Aug 22, 2025

View reviewed changes

source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated Show resolved Hide resolved

acolombier requested a review from ronso0 September 10, 2025 23:03

acolombier force-pushed the feat/s4-mk3-screens branch from 68e94dc to 93eee16 Compare September 14, 2025 12:28

S4MK3: add support for screens

8c95c0f

acolombier force-pushed the feat/s4-mk3-screens branch from 93eee16 to b4dfcbc Compare September 14, 2025 22:54

acolombier force-pushed the feat/s4-mk3-screens branch from b4dfcbc to 8c95c0f Compare September 15, 2025 18:09

ywwg reviewed Sep 23, 2025

View reviewed changes

ywwg reviewed Sep 25, 2025

View reviewed changes

	\| Hotcue color \| This mode is enabled while :hwlabel:`HOTCUES` is held down \|
	\| Hotcue color \| This mode is enabled after holding :hwlabel:`HOTCUES` for a short period of time \|

	5. Hotcue color: When holding both :hwlabel:`HOTCUES` and a hotcue, the move encoder can be used to change the selected color.
	5. Hotcue color: When first holding :hwlabel:`HOTCUES`, then tapping a specific hotcue, the move encoder can be used to change the selected color.

S4MK3: add support for Stem, rework hotcues and add beatjumps #703

Are you sure you want to change the base?

S4MK3: add support for Stem, rework hotcues and add beatjumps #703

Uh oh!

Conversation

acolombier commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acolombier commented Dec 6, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Mar 10, 2025

Uh oh!

acolombier commented Mar 10, 2025

Uh oh!

acolombier commented Aug 18, 2025

Uh oh!

Uh oh!

ywwg left a comment

Choose a reason for hiding this comment

Uh oh!

ywwg commented Aug 21, 2025

Uh oh!

acolombier commented Aug 21, 2025

Uh oh!

ywwg commented Aug 22, 2025

Uh oh!

ywwg commented Aug 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SamWhited commented Sep 14, 2025

Uh oh!

acolombier commented Sep 14, 2025

Uh oh!

ronso0 commented Sep 14, 2025

Uh oh!

acolombier commented Sep 14, 2025

Uh oh!

acolombier commented Sep 14, 2025

Uh oh!

ronso0 commented Sep 14, 2025

Uh oh!

ywwg commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ywwg commented Sep 22, 2025

Uh oh!

ronso0 commented Sep 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ywwg Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

acolombier commented Dec 6, 2024 •

edited

Loading

ywwg commented Sep 15, 2025 •

edited

Loading

ronso0 Sep 23, 2025 •

edited

Loading

ywwg Sep 24, 2025 •

edited

Loading

ywwg Sep 24, 2025 •

edited

Loading

ywwg Sep 24, 2025 •

edited

Loading

acolombier commented Sep 24, 2025 •

edited

Loading

ywwg Sep 25, 2025 •

edited

Loading