Skip to content

Commit

Permalink
Fixed a bug in params where falsy default params are not respected. (#…
Browse files Browse the repository at this point in the history
…174)

* Fixed misc bugs in panel params / appState

* Force webdriver resolution

* Remove runtime checks for appState and state
  • Loading branch information
hans-lizihan authored Dec 19, 2022
1 parent 3938b8d commit 2727b78
Show file tree
Hide file tree
Showing 5 changed files with 1,621 additions and 1,274 deletions.
2 changes: 1 addition & 1 deletion lib/component.js
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ class Component extends WebComponent {
}
const paramValue = params[paramName];
// set default value if undefined value passed in
if (paramSchema.default && paramValue === undefined) {
if (paramSchema.default !== undefined && paramValue === undefined) {
params[paramName] = paramSchema.default;
}
}
Expand Down
Loading

0 comments on commit 2727b78

Please sign in to comment.