Skip to content

SwiftUI preview fix #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023
Merged

SwiftUI preview fix #581

merged 2 commits into from
Feb 28, 2023

Conversation

RamblinWreck77
Copy link
Contributor

Don't fire this assert in the simulator (SwiftUI Preview), as the new SwiftUI lifecycle doesn't initialize Main view controller in child views so the SDK will likely not be configured

Don't fire this assert in the simulator (SwiftUI Preview), as the new SwiftUI lifecycle doesn't initialize Main view controller in child views so the SDK will likely not be configured
@jaredmixpanel
Copy link
Contributor

@RamblinWreck77 can you please pull in the latest changes from master? they include some CI config changes that will fix your CI failure.

Sync up with mixpanel master
@RamblinWreck77
Copy link
Contributor Author

@jaredmixpanel Done! Looks like that worked, thanks

Copy link
Contributor

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jaredmixpanel jaredmixpanel merged commit e1bf4b2 into mixpanel:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants