Only disable InsecureRequestWarning when verify_cert=False. #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team is upgrading to the latest Mixpanel version, and we noticed the behavior change of
verify_certmoving toFalseby default.We would like to use
verify_cert=True, but I noticed thatMixpanel.__init__is disabling urllib3 warnings regardless of theverify_certvalue. By disabling this warning in urllib3 unguarded in__init__, I think the Mixpanel library is effectively disabling this warning for any libraries that use urllib3.This branch changes that so that the warnings will only be disabled if the
verify_certvalue is left in its more insecure default mode ofFalse.Thanks for the consideration!