Skip to content

Conversation

@mblayman
Copy link
Contributor

@mblayman mblayman commented Jun 9, 2021

My team is upgrading to the latest Mixpanel version, and we noticed the behavior change of verify_cert moving to False by default.

We would like to use verify_cert=True, but I noticed that Mixpanel.__init__ is disabling urllib3 warnings regardless of the verify_cert value. By disabling this warning in urllib3 unguarded in __init__, I think the Mixpanel library is effectively disabling this warning for any libraries that use urllib3.

This branch changes that so that the warnings will only be disabled if the verify_cert value is left in its more insecure default mode of False.

Thanks for the consideration!

@seizethedave
Copy link
Contributor

Looks good to me. Thanks for the PR!

@seizethedave seizethedave merged commit d6ec4cf into mixpanel:master Jun 12, 2021
@mblayman mblayman deleted the disable-insecure-warning-only-with-false-verify-cert branch June 13, 2021 00:18
@seizethedave
Copy link
Contributor

@seizethedave
Copy link
Contributor

@mblayman Thanks for reminding me that things were in this state. I have just released #103 as 4.9.0 letting requests manage all of the TLS cert administrivia, and turning verification back on by default. Let me know how it works for you.

@mblayman
Copy link
Contributor Author

I appreciate the update. My team hasn't updated yet because we're not always right on top of dependency upgrades. I'm guessing it will work great because requests is solid, but I'll report back if we hit any issues. Thanks for taking care of this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants