Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make privacy manifest a resource, min iOS -> 11.0 #1024

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Make privacy manifest a resource, min iOS -> 11.0 #1024

merged 2 commits into from
Mar 25, 2024

Conversation

jaredmixpanel
Copy link
Contributor

@jaredmixpanel jaredmixpanel commented Mar 25, 2024 •
edited
Loading

This PR makes the privacy manifest a resource in both Cocoapods and SPM, also in the Copy Bundle Resources build phase for all targets. Also, bumps the min iOS and tvOS targets down to 11.0, to match Swift SDK.

@jaredmixpanel jaredmixpanel changed the title Make privacy manifest a resource, min iOS -> 12.0 Make privacy manifest a resource, min iOS -> 11.0 Mar 25, 2024
zihejia
zihejia approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredmixpanel jaredmixpanel merged commit a265f52 into master Mar 25, 2024
1 check passed
@jaredmixpanel jaredmixpanel mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredmixpanel @zihejia