Use namespace list from namespaceWatcher.NamespaceStore instead of retrieving it #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-helmich
previously approved these changes
Aug 23, 2021
Member
martin-helmich
left a comment
martin-helmich
left a comment
There was a problem hiding this comment.
Thanks for your contribution -- good catch; I've added a minor suggestion for another potential (small) optimization (let me know what you think), but 👍 otherwise.
…trieving it This fixes performance issues when many secrets need to be replicated to other namespaces via replicate-to. The performance issue would be acceptable, when it would fix itself after some time after the initial replication after startup. However, with the current solution, the liveness probe never gets green and keep causing replicator restarts in our clusters.
codablock
force-pushed
the
fix-performance-issue
branch
from
74203b0 to
c179c0f
Compare
martin-helmich
approved these changes
Aug 23, 2021
|
Code Climate has analyzed commit 7b897b0 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes performance issues when many secrets need to be replicated to
other namespaces via replicate-to.
The performance issue would be acceptable, when it would fix itself after
some time after the initial replication after startup. However, with the
current solution, the liveness probe never gets green and keep causing
replicator restarts in our clusters.