Remove confusing 'previously unseen snapshot' message #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
force-pushed
the
previously-unseen
branch
2 times, most recently
from
6827b5b to
47d8a2b
Compare
When using `--force-update-snapshots` or `INSTA_UPDATE=always/force`, existing snapshots were showing "created previously unseen snapshot" instead of "updated snapshot", which was confusing. This removes the conditional message logic and always prints "updated snapshot" for in-place updates, which is clearer and avoids the complexity of tracking whether snapshots are "unseen". Note: The deprecated `INSTA_UPDATE=unseen` mode still has inverted logic for determining update behavior, but since that mode is deprecated (via --accept-unseen), this is acceptable. Fixes the immediate UX issue reported in the original bug. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
max-sixty
force-pushed
the
previously-unseen
branch
from
47d8a2b to
9670b15
Compare
max-sixty
changed the title
Merged
max-sixty
added a commit
that referenced
this pull request
Nov 20, 2025
## Summary Prepare for the 1.44.0 release: - Bump version to 1.44.0 in `insta/Cargo.toml` and `cargo-insta/Cargo.toml` - Update CHANGELOG.md with all changes since 1.43.2 ## Changes in 1.44.0 - Added non-interactive snapshot review and reject modes for use in non-TTY environments (LLMs, CI pipelines, scripts) #815 - Add `--disable-nextest-doctest` flag with deprecation warning #803 - Add ergonomic `--test-runner-fallback` / `--no-test-runner-fallback` flags #811 - Apply redactions to snapshot metadata #813 - Remove confusing 'previously unseen snapshot' message #812 - Speed up JSON float rendering #806 (@nyurik) - Allow globset version up to 0.4.16 #810 (@g0hl1n) - Improve documentation #814 (@tshepang) - Enforce starting newlines in assertions #563 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running
cargo insta test --force-update-snapshots --accept, existing snapshots showed:This was confusing since the snapshots weren't new - they were being updated.
Solution
Remove the conditional message logic and always print "updated snapshot" for in-place updates.
Changes
runtime.rs:558-562to always show "updated snapshot"unseenlogic is inverted (for context)Notes
The
unseenvariable still has inverted logic (truewhen file exists, not when it doesn't), which affects the deprecatedINSTA_UPDATE=unseenmode. Since that mode is deprecated, we're not fixing the logic - just removing its use in the message.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com