Spring Maven BOM dependency + remove commons-logging #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praseodym
force-pushed
the
spring-maven-bom
branch
from
3127250 to
5c61b98
Compare
The Maven "bill of materials" dependency ensures that all Spring dependencies use the same version, without having to specify them all. http://docs.spring.io/spring/docs/current/spring-framework-reference/htmlsingle/#overview-maven-bom
|
This looks promising, thanks! |
We use slf4j instead; jcl-over-slf4j needs to be a compile-time dependency because we use it in several classes. Unfortunately Maven does not have a way to exclude commons-logging globally, so we need to figure out which dependencies include it through `mvn dependency:tree` and specify an `<exclusion>` for each of them. Finally, we upgrade to slf4j 1.7.12: http://www.slf4j.org/news.html.
praseodym
force-pushed
the
spring-maven-bom
branch
from
5c61b98 to
7c30a8d
Compare
|
Now it works ✨ |
praseodym
changed the title
|
Rebased and merged in d337e14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Maven "bill of materials" dependency ensures that all Spring dependencies use the same version, without having to specify them all.
Furthermore, we remove all transitive commons-logging dependencies that are currently still present. Unfortunately Maven does not have a way to do this globally.