Skip to content

Issue 1012 (token endpoint performance) #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Issue 1012 (token endpoint performance) #1013

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebb1305
Update OAuth2AccessTokenEntity.java
strangeweaver Feb 2, 2016
8c1e7c8
Update ApprovedSite.java
strangeweaver Feb 2, 2016
ae6fbe5
Update JpaOAuth2TokenRepository.java
strangeweaver Feb 2, 2016
9e9ad1a
Update OAuth2TokenRepository.java
strangeweaver Feb 2, 2016
bcbcc5f
Update DefaultOAuth2ProviderTokenService.java
strangeweaver Feb 2, 2016
ea1f0b8
Update DefaultApprovedSiteService.java
strangeweaver Feb 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ApprovedSite.java 
Deprecated approvedAccessTokens and made mapping bi-directional
  • Loading branch information
@strangeweaver
strangeweaver committed Feb 2, 2016
commit 8c1e7c8335d15f07cd1b85ad08e91c7ac0fc9629
14 changes: 12 additions & 2 deletions openid-connect-common/src/main/java/org/mitre/openid/connect/model/ApprovedSite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,15 +229,25 @@ public boolean isExpired() {
}
}

@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY)
@JoinColumn(name="approved_site_id")
/**
* @deprecated should not be used for performance reasons also we don't maintain
* the bi-directionality in the code so could lead to in memory inconsistencies
* instead use {@code OAuth2TokenRepository.getAccessTokensForApprovedSite}.
*/
@Deprecated
@OneToMany(cascade=CascadeType.ALL, fetch=FetchType.LAZY, mappedBy = "approvedSite")
public Set<OAuth2AccessTokenEntity> getApprovedAccessTokens() {
return approvedAccessTokens;
}

/**
* @param approvedAccessTokens the approvedAccessTokens to set
*
* @deprecated should not be used for performance reasons also we don't maintain
* the bi-directionality in the code so could lead to in memory inconsistencies
* set the approvedSite on the relevant {@code OAuth2AccessTokenEntity}.
*/
@Deprecated
public void setApprovedAccessTokens(Set<OAuth2AccessTokenEntity> approvedAccessTokens) {
this.approvedAccessTokens = approvedAccessTokens;
}
Expand Down