Update RelationshipTable.vue #76
Conversation
Add display of the *values* not just the names of the facts to the fact table.
|
Additional note, I did leave these fields read only in the display process, wasn't sure if there was a risk in making them editable. I tested that as well and it didn't blow up my instance.. If that's a that more preferred option I'd be happy to update accordingly. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the fact sources relationship table by adding source and target values to the display. Previously, the table only showed trait names (source trait, edge, target trait), but now it also displays the actual values associated with those traits for better visibility and debugging.
- Added "Source Value" and "Target Value" columns to the relationship table
- Updated column headers to be more descriptive ("Source Name" instead of "Source", "Target Name" instead of "Target")
- Displayed relationship.source.value and relationship.target.value in the new columns
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| input.input(v-if="relationshipIndexToEdit === index" v-model="relationship.target.trait" placeholder="Relationship target") | ||
| span(v-else) {{ relationship.target.trait }} | ||
| td | ||
| span {{ relationship.target.value }} |
There was a problem hiding this comment.
Inconsistent indentation: this line uses 7 spaces while other similar lines use 8 spaces for indentation. Should be aligned with the pattern used in line 60.
| span {{ relationship.target.value }} | |
| span {{ relationship.target.value }} |
1 participant
I've been spending some quality time in the fact sources (see mitre/caldera#3177) and I'm more familiar with how they work now. Wanted to make the information that I've been dropping into a local debug log (fact names and associated values) visible in the UI.
Description
This updates the display on the factsources page.
Previous version only had source edge and target, but did not include the values for the relationships.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Edited the Vue file locally, rebuilt and tested. Source and target values are now part of the output. See example.
Checklist: