Standardize and Improve Plugin Logs

[KirilldogU]

Resolves #915

Standardize and add to the plugin logs for consistency, clarity, and increased utility for debugging.

All plugin queries produce an INFO level log "running query_name query" at start and INFO level "completed query_name query" at successful resolution. The linguist plugin is an exception and it logs queries at the DEBUG level because it produces thousands of logs due to repeated is_source_file() calls.

All plugins which use the plugin engine to query other plugins also produce TRACE level logs at that point.

[KirilldogU]

This PR adds INFO start/end logs to all the plugins except: npm, linguist, git, and github. Those plugins appear to be used by the other plugins during analysis and do not provide their own analysis metric so I chose to leave them without this INFO log.
Is this correct?

[alilleybrinker]

This PR adds INFO start/end logs to all the plugins except: npm, linguist, git, and github. Those plugins appear to be used by the other plugins during analysis and do not provide their own analysis metric so I chose to leave them without this INFO log. Is this correct?

I'd still add it. They're not "top-level" plugins (they don't expose a default query), but it can still be useful for debugging to know when they're running.

[j-lanson]

This PR adds INFO start/end logs to all the plugins except: npm, linguist, git, and github. Those plugins appear to be used by the other plugins during analysis and do not provide their own analysis metric so I chose to leave them without this INFO log. Is this correct?

I'd still add it. They're not "top-level" plugins (they don't expose a default query), but it can still be useful for debugging to know when they're running.

I agree with Andrew, the reason we did the work of adding parsing and per-plugin control through HC_LOG was so that people can turn off / reduce the log level of plugins as they wish. If they don't want a bunch of git plugin logs they can do HC_LOG=plugin::git=warn

[j-lanson]

Looks good Kirill, thanks!