Adding Log In/Out and CORS functionality for the Vue dev Server #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argaudreau
reviewed
Jun 29, 2022
|
You'll also want to remove Magma from the |
So I did remove it from .gitmodules and it's still failing, not sure what's going on with that... |
JamieScottC
approved these changes
Jul 14, 2022
elegantmoose
pushed a commit
that referenced
this pull request
Feb 11, 2024
* Enable cors in server * cors now working with login api * return status 401 on wrong credentials * cleaning up the app_svc file a bit * change logout endpoint to stop serving template * CORS now working on localhost:3000 * Add aiohttp-cors to requirements file * Removing magma as a submodule in order to pass git tests * Remove magma submodule * Add back optional param for requirements * Add compiled front-end dist directory Co-authored-by: Adam Gaudreau <agaudreau@mitre.org> Co-authored-by: Palmer <zpalmer@mm273285-pc.lan> Co-authored-by: JamieScottC <scott.jams@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combo PR between myself and Jamie. Adding in the Logging in and out functionality to Magma and enabling cors on the various API routes so that we can utilize the Vue development server for front end development
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Verified that we are now able to access the API's on localhost:3000 and we are now able to login and logout as expected.
Checklist: