Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons are lined up on the adversary page #2615

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Buttons are lined up on the adversary page #2615

merged 1 commit into from
Jun 30, 2022

Conversation

mshkolnik22
Copy link
Contributor

Description

Buttons on the adversary page are visible and well laid out, even on smaller screens.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

image

@mshkolnik22 mshkolnik22 self-assigned this Jun 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

argaudreau
argaudreau approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@argaudreau argaudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Good to merge

JamieScottC
JamieScottC approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@JamieScottC JamieScottC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@argaudreau argaudreau merged commit 1b311ba into master Jun 30, 2022
@argaudreau argaudreau deleted the ms-buttons-on-adversaries branch June 30, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argaudreau argaudreau argaudreau approved these changes

@JamieScottC JamieScottC JamieScottC approved these changes

@ZacharyLPalmer ZacharyLPalmer Awaiting requested review from ZacharyLPalmer

Assignees

@mshkolnik22 mshkolnik22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshkolnik22 @JamieScottC @argaudreau